| Summary: | WPT test MediaStreamTrack-MediaElement-disabled-video-is-black.https.html fails | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||
| Component: | WebRTC | Assignee: | Eric Carlson <eric.carlson> | ||||||
| Status: | RESOLVED CONFIGURATION CHANGED | ||||||||
| Severity: | Normal | CC: | ap, ews-watchlist, glenn, hta, jer.noble, jonlee, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Other | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Eric Carlson
2019-11-09 13:59:00 PST
Created attachment 383225 [details]
Patch
Comment on attachment 383225 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383225&action=review > Source/WebCore/ChangeLog:8 > + No new tests, this fixes an existing test. I don't see any failures on the flakiness dashboard, and there are no TestExpectations for it. How exactly does this test cover the fix? (In reply to Alexey Proskuryakov from comment #2) > > I don't see any failures on the flakiness dashboard, and there are no > TestExpectations for it. How exactly does this test cover the fix? Indeed, the test in our repository had a syntax error so it was continuing to fail even though the test in the WPT repository passes with these changes. I updated all of the mediacapture-streams in https://bugs.webkit.org/show_bug.cgi?id=204073, so I'll add new results to this test. Created attachment 383872 [details]
Update test result
Ping! Is this patch still good? (In reply to Jon Lee from comment #6) > Ping! Is this patch still good? I don't know, we'll have to try it. Test is now passing. Probably the patch does not apply with the changes done to the media player for out of main thread processing. It might be worth checking though if some parts of the patch should be rebased. |