Bug 204052 - WPT test MediaStreamTrack-MediaElement-disabled-video-is-black.https.html fails
Summary: WPT test MediaStreamTrack-MediaElement-disabled-video-is-black.https.html fails
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-09 13:59 PST by Eric Carlson
Modified: 2021-01-06 09:53 PST (History)
11 users (show)

See Also:


Attachments
Patch (3.72 KB, patch)
2019-11-09 14:04 PST, Eric Carlson
no flags Details | Formatted Diff | Diff
Update test result (5.55 KB, patch)
2019-11-19 08:38 PST, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2019-11-09 13:59:00 PST
WPT test MediaStreamTrack-MediaElement-disabled-video-is-black.https.html fails
Comment 1 Eric Carlson 2019-11-09 14:04:12 PST
Created attachment 383225 [details]
Patch
Comment 2 Alexey Proskuryakov 2019-11-10 14:03:52 PST
Comment on attachment 383225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383225&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests, this fixes an existing test.

I don't see any failures on the flakiness dashboard, and there are no TestExpectations for it. How exactly does this test cover the fix?
Comment 3 Eric Carlson 2019-11-11 10:43:54 PST
(In reply to Alexey Proskuryakov from comment #2)
> 
> I don't see any failures on the flakiness dashboard, and there are no
> TestExpectations for it. How exactly does this test cover the fix?

Indeed, the test in our repository had a syntax error so it was continuing to fail even though the test in the WPT repository passes with these changes. 

I updated all of the mediacapture-streams in https://bugs.webkit.org/show_bug.cgi?id=204073, so I'll add new results to this test.
Comment 4 Radar WebKit Bug Importer 2019-11-19 08:35:40 PST
<rdar://problem/57322974>
Comment 5 Eric Carlson 2019-11-19 08:38:44 PST
Created attachment 383872 [details]
Update test result
Comment 6 Jon Lee 2020-04-10 14:31:35 PDT
Ping! Is this patch still good?
Comment 7 Eric Carlson 2020-04-10 15:36:47 PDT
(In reply to Jon Lee from comment #6)
> Ping! Is this patch still good?

I don't know, we'll have to try it.
Comment 8 youenn fablet 2020-05-30 01:17:26 PDT
Test is now passing. Probably the patch does not apply with the changes done to the media player for out of main thread processing.
It might be worth checking though if some parts of the patch should be rebased.
Comment 9 Eric Carlson 2020-06-08 11:34:44 PDT
Closing, Youenn fixed this in r261553.