Summary: | Long-pressing support.apple.com categories shows a PNG instead of the web page preview, tapping loads image asset only instead of web page | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
Component: | New Bugs | Assignee: | Dean Jackson <dino> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=204058 | ||||||
Attachments: |
|
Description
Dean Jackson
2019-11-08 17:43:00 PST
Created attachment 383189 [details]
Patch
Comment on attachment 383189 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383189&action=review > Source/WebKit/ChangeLog:10 > + Sometime recently, Safari started using our ContextMenu API rather than the old SPI. At that > + point they accidentally began providing a PreviewViewController that displayed the image Maybe reword this. > Source/WebKit/ChangeLog:15 > + This could be fixed in Safari, but I noticed that we actually tell the delegate that the > + type of the activated element is an image, which is why they treat it as such. It's not > + clear that because the image also has a link attached, a client should defer to the link. Are we not able to tell the client "link and image"? Committed r252309: <https://trac.webkit.org/changeset/252309> (In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 383189 [details] > > Are we not able to tell the client "link and image"? We do. We don't give them a type, just information on whether there is a link and whether there is an image. The client decides what to do. (In reply to Dean Jackson from comment #4) > Committed r252309: <https://trac.webkit.org/changeset/252309> The newly added API test TestWebKitAPI._WKActivatedElementInfo.InfoForLinkAroundImage is failing consistently on iOS. EWS status-bubble for api-ios was also red and indicated this failure. Tracked in Bug 204058. |