Bug 204009

Summary: [Web Animations] Optimize animation resolution to not re-compute whether effects only contain accelerated animation properties
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cmarcelo, dbates, dino, esprehn+autocc, ews-watchlist, kangil.han, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=204010
Attachments:
Description Flags
Patch dino: review+

Antoine Quint
Reported 2019-11-08 09:58:20 PST
When resolving animations we re-compute whether all animated properties are accelerated to return the `shouldRecompositeLayer` flag in TreeResolver::createAnimatedElementUpdate. We should be able to expose such a property when keyframes on a KeyframeEffect change and then also store it on KeyframeEffectStack and compute that value when the stack is changed.
Attachments
Patch (2.23 KB, patch)
2019-11-08 13:04 PST, Antoine Quint 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2019-11-08 10:22:24 PST
Retitling because it will likely be enough to do it on just KeyframeEffect since we have to iterate through all the effects of a stack when resolving anyway.
Antoine Quint
Comment 2 2019-11-08 13:02:10 PST
As it turns out KeyframeEffect already caches this information, we just need to use it!
Antoine Quint
Comment 3 2019-11-08 13:04:08 PST
Created attachment 383154 [details] Patch
Dean Jackson
Comment 4 2019-11-08 13:18:29 PST
Comment on attachment 383154 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383154&action=review > Source/WebCore/ChangeLog:9 > + of iterating over an effec'ts animated properties during resolution to get at the same information. typo
Antoine Quint
Comment 5 2019-11-09 03:05:30 PST
Committed r252307: <https://trac.webkit.org/changeset/252307>
Radar WebKit Bug Importer
Comment 6 2019-11-11 16:59:04 PST
<rdar://problem/57099367>
Note You need to log in before you can comment on or make changes to this bug.