Bug 203999

Summary: [macOS] Add logging and telemetry to mach lookup rules
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
bfulgham: review+
Patch none

Per Arne Vollan
Reported 2019-11-08 08:06:39 PST
Add logging and telemetry to help determine if mach lookup can be denied in the WebContent process.
Attachments
Patch (3.23 KB, patch)
2019-11-08 08:15 PST, Per Arne Vollan 		bfulgham: review+
DetailsFormatted DiffDiff
Patch (3.29 KB, patch)
2019-11-08 11:38 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-11-08 08:07:16 PST
<rdar://problem/57021686>
Per Arne Vollan
Comment 2 2019-11-08 08:15:57 PST
Created attachment 383127 [details] Patch
Brent Fulgham
Comment 3 2019-11-08 11:02:37 PST
Comment on attachment 383127 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383127&action=review r=me > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:601 > +) These look fine, but we seem to be hitting test failures (which seems crazy to me). Can you double-check we don't have a syntax error in the sandbox?
Per Arne Vollan
Comment 4 2019-11-08 11:18:04 PST
(In reply to Brent Fulgham from comment #3) > Comment on attachment 383127 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=383127&action=review > > r=me > > > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:601 > > +) > > These look fine, but we seem to be hitting test failures (which seems crazy > to me). Can you double-check we don't have a syntax error in the sandbox? Yes, investigating now :) Thanks for reviewing!
Per Arne Vollan
Comment 5 2019-11-08 11:38:11 PST
Created attachment 383148 [details] Patch
WebKit Commit Bot
Comment 6 2019-11-08 13:35:18 PST
Comment on attachment 383148 [details] Patch Clearing flags on attachment: 383148 Committed r252261: <https://trac.webkit.org/changeset/252261>
Note You need to log in before you can comment on or make changes to this bug.