Summary: | Regression r252209: Layout Test fast/workers/worker-close-more.html is failing | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
Component: | Tools / Tests | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, achristensen, cdumez, commit-queue, ggaren, rniwa, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=203960 | ||||||
Attachments: |
|
Description
Aakash Jain
2019-11-08 07:05:13 PST
Sample failure: https://ews-build.webkit.org/results/macOS-High-Sierra-Debug-WK1-Tests-EWS/r383034-6067-clean-tree/results.html Diff: PASS: workerThreadCount = 0 PASS: MessagePort multiple message test, received message: echo_ping1 +FAIL: The MessagePort message was dispatched after a JS fragment that called 'close()' exited. +PASS: MessagePort messages were not delivered asfter close(). +DONE PASS: MessagePort messages were not delivered asfter close(). DONE Looking. I think WorkerMessagingProxy::workerGlobalScopeClosed() needs to be ported to the Event Loop too, or the ordering between posting a message and closing the worker global scope is no longer correct. I will confirm. Created attachment 383130 [details]
Patch
Comment on attachment 383130 [details] Patch Clearing flags on attachment: 383130 Committed r252242: <https://trac.webkit.org/changeset/252242> All reviewed patches have been landed. Closing bug. |