Bug 203995 - Regression r252209: Layout Test fast/workers/worker-close-more.html is failing
Summary: Regression r252209: Layout Test fast/workers/worker-close-more.html is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-08 07:05 PST by Aakash Jain
Modified: 2019-11-08 10:24 PST (History)
10 users (show)

See Also:


Attachments
Patch (1.51 KB, patch)
2019-11-08 09:15 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-11-08 07:05:13 PST
The following layout test is failing on all the platforms: fast/workers/worker-close-more.html

Flakiness Dashboard:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fworkers%2Fworker-close-more.html
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fworkers%2Fworker-close-more.html


Probable cause:
It passed in r252208 and failed in r252210. Most likely a regression from r252209 https://trac.webkit.org/changeset/252209/webkit 
https://bugs.webkit.org/show_bug.cgi?id=203960 'Port MessagePort to the HTML5 event loop'
Comment 1 Aakash Jain 2019-11-08 07:05:39 PST
Sample failure:
https://ews-build.webkit.org/results/macOS-High-Sierra-Debug-WK1-Tests-EWS/r383034-6067-clean-tree/results.html

Diff:
 PASS: workerThreadCount = 0
 PASS: MessagePort multiple message test, received message: echo_ping1
+FAIL: The MessagePort message was dispatched after a JS fragment that called 'close()' exited.
+PASS: MessagePort messages were not delivered asfter close().
+DONE
 PASS: MessagePort messages were not delivered asfter close().
 DONE
Comment 2 Radar WebKit Bug Importer 2019-11-08 07:08:04 PST
<rdar://problem/57020558>
Comment 3 Chris Dumez 2019-11-08 08:05:21 PST
Looking.
Comment 4 Chris Dumez 2019-11-08 08:15:44 PST
I think WorkerMessagingProxy::workerGlobalScopeClosed() needs to be ported to the Event Loop too, or the ordering between posting a message and closing the worker global scope is no longer correct. I will confirm.
Comment 5 Chris Dumez 2019-11-08 09:15:12 PST
Created attachment 383130 [details]
Patch
Comment 6 WebKit Commit Bot 2019-11-08 10:24:30 PST
Comment on attachment 383130 [details]
Patch

Clearing flags on attachment: 383130

Committed r252242: <https://trac.webkit.org/changeset/252242>
Comment 7 WebKit Commit Bot 2019-11-08 10:24:32 PST
All reviewed patches have been landed.  Closing bug.