Summary: | [GTK] WebDriver: implement new window command | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||
Component: | WebDriver | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, berto, bugs-noreply, clopez, ews-watchlist, gustavo, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2019-11-08 06:07:21 PST
Adding GTK since this requires new API. Created attachment 383122 [details]
Patch
This patch includes unit tests for the new GLib API, but we don'tm have WebDriver tests for the new window command in WebKit tree yet. I've run wpt tests and all pass. I'll update the imported wpt tests in WebKit after landing this.
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Created attachment 383258 [details]
Patch
Comment on attachment 383258 [details]
Patch
r=me.
I guess this needs a second review since it adds new public API.
Committed r252356: <https://trac.webkit.org/changeset/252356> |