Bug 203994

Summary: [GTK] WebDriver: implement new window command
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebDriverAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, berto, bugs-noreply, clopez, ews-watchlist, gustavo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch clopez: review+, clopez: commit-queue-

Carlos Garcia Campos
Reported 2019-11-08 06:07:21 PST
11.5 New Window https://w3c.github.io/webdriver/#new-window
Attachments
Patch (30.82 KB, patch)
2019-11-08 06:44 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (32.18 KB, patch)
2019-11-11 02:45 PST, Carlos Garcia Campos 		clopez: review+
clopez: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2019-11-08 06:08:31 PST
Adding GTK since this requires new API.
Carlos Garcia Campos
Comment 2 2019-11-08 06:44:22 PST
Created attachment 383122 [details] Patch This patch includes unit tests for the new GLib API, but we don'tm have WebDriver tests for the new window command in WebKit tree yet. I've run wpt tests and all pass. I'll update the imported wpt tests in WebKit after landing this.
EWS Watchlist
Comment 3 2019-11-08 06:45:25 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 4 2019-11-11 02:45:06 PST
Created attachment 383258 [details] Patch
Carlos Alberto Lopez Perez
Comment 5 2019-11-11 13:33:53 PST
Comment on attachment 383258 [details] Patch r=me. I guess this needs a second review since it adds new public API.
Carlos Garcia Campos
Comment 6 2019-11-12 00:12:47 PST
Committed r252356: <https://trac.webkit.org/changeset/252356>
Radar WebKit Bug Importer
Comment 7 2019-11-12 00:13:15 PST
<rdar://problem/57107742>
Note You need to log in before you can comment on or make changes to this bug.