Summary: | Make DownloadID an ObjectIdentifier | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||||||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | cdumez, ggaren, jbedard, webkit-bug-importer, youennf | ||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
Attachments: |
|
Description
Alex Christensen
2019-11-07 09:30:35 PST
Created attachment 383057 [details]
Patch
Looks like there are some build issues. Created attachment 383072 [details]
Patch
Comment on attachment 383072 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383072&action=review > Source/WebKit/NetworkProcess/NetworkProcess.cpp:1970 > + downloadProxyConnection()->send(Messages::DownloadProxy::DidCancel({ }), downloadID.toUInt64()); We can probably remove toUInt64() here and in every send() call site below. > Source/WebKit/NetworkProcess/NetworkProcess.cpp:1975 > + uint64_t destinationID = networkDataTask.pendingDownloadID().toUInt64(); auto destinationID = networkDataTask.pendingDownloadID(); or directly inline the call where used. Reverted r252260 for reason: Breaks half of API tests Committed r252274: <https://trac.webkit.org/changeset/252274> My rollout was a bit blind, but given how conclusive https://results.webkit.org/suites?suite=api-tests was, I thought justified. Seems like this breaks Debug API tests That was a case of sending a default-constructed DownloadID instead of using an Optional<DownloadID> and sending nullopt. Will fix and rebase. Created attachment 410560 [details]
Patch
Created attachment 410562 [details]
Patch
Created attachment 410569 [details]
Patch
Created attachment 410573 [details]
Patch
Created attachment 410585 [details]
Patch
Comment on attachment 410585 [details]
Patch
r=me
|