Bug 203962

Summary:

Make DownloadID an ObjectIdentifier

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, ggaren, jbedard, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ggaren: review+

Alex Christensen

Reported 2019-11-07 09:30:35 PST

Make DownloadID an ObjectIdentifier

Attachments
Patch (26.92 KB, patch) 2019-11-07 09:33 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (27.31 KB, patch) 2019-11-07 14:27 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (339.31 KB, patch) 2020-10-05 14:35 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (35.25 KB, patch) 2020-10-05 14:36 PDT, Alex Christensen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (35.08 KB, patch) 2020-10-05 15:26 PDT, Alex Christensen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (34.69 KB, patch) 2020-10-05 15:42 PDT, Alex Christensen	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (35.21 KB, patch) 2020-10-05 16:31 PDT, Alex Christensen	ggaren: review+	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2019-11-07 09:33:09 PST

Created attachment 383057 [details] Patch

Chris Dumez

Comment 2 2019-11-07 10:20:39 PST

Looks like there are some build issues.

Alex Christensen

Comment 3 2019-11-07 14:27:50 PST

Created attachment 383072 [details] Patch

youenn fablet

Comment 4 2019-11-08 06:47:23 PST

Comment on attachment 383072 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383072&action=review > Source/WebKit/NetworkProcess/NetworkProcess.cpp:1970 > + downloadProxyConnection()->send(Messages::DownloadProxy::DidCancel({ }), downloadID.toUInt64()); We can probably remove toUInt64() here and in every send() call site below. > Source/WebKit/NetworkProcess/NetworkProcess.cpp:1975 > + uint64_t destinationID = networkDataTask.pendingDownloadID().toUInt64(); auto destinationID = networkDataTask.pendingDownloadID(); or directly inline the call where used.

Alex Christensen

Comment 5 2019-11-08 13:35:05 PST

http://trac.webkit.org/r252260

Radar WebKit Bug Importer

Comment 6 2019-11-08 13:36:16 PST

<rdar://problem/57032761>

Jonathan Bedard

Comment 7 2019-11-08 16:20:06 PST

Reverted r252260 for reason: Breaks half of API tests Committed r252274: <https://trac.webkit.org/changeset/252274>

Jonathan Bedard

Comment 8 2019-11-08 16:21:02 PST

My rollout was a bit blind, but given how conclusive https://results.webkit.org/suites?suite=api-tests was, I thought justified. Seems like this breaks Debug API tests

Alex Christensen

Comment 9 2020-10-05 14:34:13 PDT

That was a case of sending a default-constructed DownloadID instead of using an Optional<DownloadID> and sending nullopt. Will fix and rebase.

Alex Christensen

Comment 10 2020-10-05 14:35:07 PDT

Created attachment 410560 [details] Patch

Alex Christensen

Comment 11 2020-10-05 14:36:22 PDT

Created attachment 410562 [details] Patch

Alex Christensen

Comment 12 2020-10-05 15:26:02 PDT

Created attachment 410569 [details] Patch