Bug 203958

Summary: Many resourceLoadStatistics tests and storageAccess tests using the ITP Database redirect to the corresponding memory store test after setting a cookie
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: Tools / TestsAssignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kate Cheney
Reported 2019-11-07 08:57:43 PST
Many resourceLoadStatistics tests and storageAccess tests using the ITP Database redirect to the corresponding memory store test after setting a cookie, as opposed to redirecting back to themselves. This went unnoticed because the test files are identical after the initialization of the store. I think its important to fix these instances to prevent future confusion over failures if any files redirected-to are removed or edited.
Attachments
Patch (24.49 KB, patch)
2019-11-07 09:47 PST, Kate Cheney 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-11-07 08:59:04 PST
<rdar://problem/56984114>
Kate Cheney
Comment 2 2019-11-07 09:47:21 PST
Created attachment 383059 [details] Patch
John Wilander
Comment 3 2019-11-07 14:15:11 PST
API tests on iOS "New failures: set([u'TestWebKitAPI.ServiceWorkers.ThrottleCrash'])" looks unrelated.
John Wilander
Comment 4 2019-11-07 14:18:30 PST
Comment on attachment 383059 [details] Patch Looks good! As discussed, we should come up with a way to make it simple to get it right, such as generating the redirect URL based on the test case's start URL or by generating the HTML file's name from a descriptive string such as "Request and grant access then detach should not have access" -> "request-and-grant-access-then-detach-should-not-have-access.html".
WebKit Commit Bot
Comment 5 2019-11-07 15:16:45 PST
Comment on attachment 383059 [details] Patch Clearing flags on attachment: 383059 Committed r252210: <https://trac.webkit.org/changeset/252210>
WebKit Commit Bot
Comment 6 2019-11-07 15:16:47 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.