Bug 203895

Summary: Indentation in ThreadGlobalData.h is incorrect
Product: WebKit Reporter: Chris Lord <clord>
Component: WebCore Misc.Assignee: Chris Lord <clord>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, commit-queue, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 182686    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-cq-03 for mac-highsierra none

Description Chris Lord 2019-11-06 05:19:07 PST 
Currently, if you want to make a change to ThreadGlobalData.h, the style checker will likely complain, as the indentation in this file is incorrect. Either your change will look wrong or you'll need to re-indent the file. Filing this bug to do the latter without any unrelated changes.
Comment 1 Chris Lord 2019-11-06 05:24:06 PST 
Created attachment 382920 [details]
Patch
Comment 2 WebKit Commit Bot 2019-11-06 10:10:27 PST 
Comment on attachment 382920 [details]
Patch

Rejecting attachment 382920 [details] from commit-queue.

New failing tests:
webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html
Full output: https://webkit-queues.webkit.org/results/13219394
Comment 3 WebKit Commit Bot 2019-11-06 10:10:29 PST 
Created attachment 382937 [details]
Archive of layout-test-results from webkit-cq-03 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 4 Adrian Perez 2019-11-07 01:09:34 PST 
Comment on attachment 382920 [details]
Patch

Setting cq+, indentation changes are unrelated to the EWS failures.
Comment 5 WebKit Commit Bot 2019-11-07 01:52:35 PST 
Comment on attachment 382920 [details]
Patch

Clearing flags on attachment: 382920

Committed r252179: <https://trac.webkit.org/changeset/252179>
Comment 6 WebKit Commit Bot 2019-11-07 01:52:36 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-11-07 01:53:40 PST 
<rdar://problem/56976363>