Bug 203895

Summary: Indentation in ThreadGlobalData.h is incorrect
Product: WebKit Reporter: Chris Lord <clord>
Component: WebCore Misc.Assignee: Chris Lord <clord>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, commit-queue, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 182686    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-cq-03 for mac-highsierra none

Chris Lord
Reported 2019-11-06 05:19:07 PST
Currently, if you want to make a change to ThreadGlobalData.h, the style checker will likely complain, as the indentation in this file is incorrect. Either your change will look wrong or you'll need to re-indent the file. Filing this bug to do the latter without any unrelated changes.
Attachments
Patch (5.72 KB, patch)
2019-11-06 05:24 PST, Chris Lord 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-cq-03 for mac-highsierra (3.46 MB, application/zip)
2019-11-06 10:10 PST, WebKit Commit Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Chris Lord
Comment 1 2019-11-06 05:24:06 PST
Created attachment 382920 [details] Patch
WebKit Commit Bot
Comment 2 2019-11-06 10:10:27 PST
Comment on attachment 382920 [details] Patch Rejecting attachment 382920 [details] from commit-queue. New failing tests: webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html Full output: https://webkit-queues.webkit.org/results/13219394
WebKit Commit Bot
Comment 3 2019-11-06 10:10:29 PST
Created attachment 382937 [details] Archive of layout-test-results from webkit-cq-03 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-03 Port: mac-highsierra Platform: Mac OS X 10.13.6
Adrian Perez
Comment 4 2019-11-07 01:09:34 PST
Comment on attachment 382920 [details] Patch Setting cq+, indentation changes are unrelated to the EWS failures.
WebKit Commit Bot
Comment 5 2019-11-07 01:52:35 PST
Comment on attachment 382920 [details] Patch Clearing flags on attachment: 382920 Committed r252179: <https://trac.webkit.org/changeset/252179>
WebKit Commit Bot
Comment 6 2019-11-07 01:52:36 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-11-07 01:53:40 PST
<rdar://problem/56976363>
Note You need to log in before you can comment on or make changes to this bug.