Bug 203883

Summary: Keep None value at the end of the ListStyleType enum
Product: WebKit Reporter: Oriol Brufau <obrufau>
Component: CSSAssignee: Oriol Brufau <obrufau>
Status: RESOLVED INVALID    
Severity: Normal CC: commit-queue, esprehn+autocc, ews-watchlist, glenn, jlewis3, kondapallykalyan, pdr, rego, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 167729    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Oriol Brufau
Reported 2019-11-06 01:34:12 PST
(In reply to Simon Fraser (smfr) from bug 167729 comment #18) > Comment on attachment 382768 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=382768&action=review > > > Source/WebCore/rendering/style/RenderStyleConstants.h:635 > > + None, > > + String > > Seems odd not to keep None at the end.
Attachments
Patch (1.33 KB, patch)
2019-11-06 01:36 PST, Oriol Brufau 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oriol Brufau
Comment 1 2019-11-06 01:36:05 PST
Created attachment 382906 [details] Patch
WebKit Commit Bot
Comment 2 2019-11-06 14:39:04 PST
Comment on attachment 382906 [details] Patch Clearing flags on attachment: 382906 Committed r252151: <https://trac.webkit.org/changeset/252151>
WebKit Commit Bot
Comment 3 2019-11-06 14:39:05 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-11-06 14:40:17 PST
<rdar://problem/56959364>
Matt Lewis
Comment 5 2019-11-11 11:01:58 PST
Reverted r252151 for reason: This broke internal builds and tests along with https://bugs.webkit.org/show_bug.cgi?id=167729#c18. For more information discuss with your reviewers. Committed r252334: <https://trac.webkit.org/changeset/252334>
Oriol Brufau
Comment 6 2019-11-13 02:32:36 PST
No longer relevant since bug 167729 was reverted. If I reland bug 167729, I will include the fix there.
Note You need to log in before you can comment on or make changes to this bug.