Bug 203883

Summary: Keep None value at the end of the ListStyleType enum
Product: WebKit Reporter: Oriol Brufau <obrufau>
Component: CSSAssignee: Oriol Brufau <obrufau>
Status: RESOLVED INVALID    
Severity: Normal CC: commit-queue, esprehn+autocc, ews-watchlist, glenn, jlewis3, kondapallykalyan, pdr, rego, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 167729    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Oriol Brufau 2019-11-06 01:34:12 PST 
(In reply to Simon Fraser (smfr) from bug 167729 comment #18)
> Comment on attachment 382768 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=382768&action=review
> 
> > Source/WebCore/rendering/style/RenderStyleConstants.h:635
> > +    None,
> > +    String
> 
> Seems odd not to keep None at the end.
Comment 1 Oriol Brufau 2019-11-06 01:36:05 PST 
Created attachment 382906 [details]
Patch
Comment 2 WebKit Commit Bot 2019-11-06 14:39:04 PST 
Comment on attachment 382906 [details]
Patch

Clearing flags on attachment: 382906

Committed r252151: <https://trac.webkit.org/changeset/252151>
Comment 3 WebKit Commit Bot 2019-11-06 14:39:05 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-11-06 14:40:17 PST 
<rdar://problem/56959364>
Comment 5 Matt Lewis 2019-11-11 11:01:58 PST 
Reverted r252151 for reason:

This broke internal builds and tests along with https://bugs.webkit.org/show_bug.cgi?id=167729#c18. For more information discuss with your reviewers.

Committed r252334: <https://trac.webkit.org/changeset/252334>
Comment 6 Oriol Brufau 2019-11-13 02:32:36 PST 
No longer relevant since bug 167729 was reverted.
If I reland bug 167729, I will include the fix there.