Bug 203879

Summary: [Win] DumpRenderTree.exe and WebKitTestRunner.exe shouldn't link with WebCoreTestSupport
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: Tools / TestsAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bfulgham, don.olmstead, ews-watchlist, gyuyoung.kim, pvollan, ross.kirsling, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ross.kirsling: review+

Fujii Hironori
Reported 2019-11-05 21:53:35 PST
[Win] DumpRenderTree.exe and WebKitTestRunner.exe shouldn't link with WebCoreTestSupport After r252086, WinCairo DumpRenderTree.exe and WebKitTestRunner.exe can't start because they are linked with WinCairoRequirements libs.
Attachments
Patch (2.35 KB, patch)
2019-11-05 22:01 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (2.35 KB, patch)
2019-11-06 06:44 PST, Fujii Hironori 		ross.kirsling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2019-11-05 22:01:52 PST
Created attachment 382895 [details] Patch
Fujii Hironori
Comment 2 2019-11-06 06:44:04 PST
Created attachment 382923 [details] Patch
Ross Kirsling
Comment 3 2019-11-06 12:12:44 PST
Comment on attachment 382923 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382923&action=review > Tools/WebKitTestRunner/PlatformWin.cmake:-39 > - WebKit I take it that this one doesn't need to be preserved in WebKitTestRunnerLib?
Fujii Hironori
Comment 4 2019-11-06 17:31:34 PST
Comment on attachment 382923 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382923&action=review >> Tools/WebKitTestRunner/PlatformWin.cmake:-39 >> - WebKit > > I take it that this one doesn't need to be preserved in WebKitTestRunnerLib? Nope. WebKitTestRunner.exe doesn't need to link with WebKit. It loads WebKitTestRunnerLib.dll by using LoadLibraryW.
Fujii Hironori
Comment 5 2019-11-06 17:39:45 PST
Comment on attachment 382923 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382923&action=review >>> Tools/WebKitTestRunner/PlatformWin.cmake:-39 >>> - WebKit >> >> I take it that this one doesn't need to be preserved in WebKitTestRunnerLib? > > Nope. WebKitTestRunner.exe doesn't need to link with WebKit. It loads WebKitTestRunnerLib.dll by using LoadLibraryW. I misread your comment. WebKitTestRunnerLib_LIBRARIES includes WebKit. CMakeLists.txt: set(WebKitTestRunner_LIBRARIES WebKit::JavaScriptCore WebCoreTestSupport WebKit ) PlatformWin.cmake: set(WebKitTestRunnerLib_LIBRARIES ${WebKitTestRunner_LIBRARIES} Comsuppw Oleacc ) list(APPEND WebKitTestRunner_LIBRARIES shlwapi )
Fujii Hironori
Comment 6 2019-11-06 18:05:30 PST
Committed r252165: <https://trac.webkit.org/changeset/252165>
Radar WebKit Bug Importer
Comment 7 2019-11-06 18:06:18 PST
<rdar://problem/56967581>
Note You need to log in before you can comment on or make changes to this bug.