Bug 203879

Summary: [Win] DumpRenderTree.exe and WebKitTestRunner.exe shouldn't link with WebCoreTestSupport
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: Tools / TestsAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bfulgham, don.olmstead, ews-watchlist, gyuyoung.kim, pvollan, ross.kirsling, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ross.kirsling: review+

Description Fujii Hironori 2019-11-05 21:53:35 PST 
[Win] DumpRenderTree.exe and WebKitTestRunner.exe shouldn't link with WebCoreTestSupport

After r252086, WinCairo DumpRenderTree.exe and
WebKitTestRunner.exe can't start because they are linked with
WinCairoRequirements libs.
Comment 1 Fujii Hironori 2019-11-05 22:01:52 PST 
Created attachment 382895 [details]
Patch
Comment 2 Fujii Hironori 2019-11-06 06:44:04 PST 
Created attachment 382923 [details]
Patch
Comment 3 Ross Kirsling 2019-11-06 12:12:44 PST 
Comment on attachment 382923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382923&action=review

> Tools/WebKitTestRunner/PlatformWin.cmake:-39
> -    WebKit

I take it that this one doesn't need to be preserved in WebKitTestRunnerLib?
Comment 4 Fujii Hironori 2019-11-06 17:31:34 PST 
Comment on attachment 382923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382923&action=review

>> Tools/WebKitTestRunner/PlatformWin.cmake:-39
>> -    WebKit
> 
> I take it that this one doesn't need to be preserved in WebKitTestRunnerLib?

Nope. WebKitTestRunner.exe doesn't need to link with WebKit. It loads WebKitTestRunnerLib.dll by using LoadLibraryW.
Comment 5 Fujii Hironori 2019-11-06 17:39:45 PST 
Comment on attachment 382923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382923&action=review

>>> Tools/WebKitTestRunner/PlatformWin.cmake:-39
>>> -    WebKit
>> 
>> I take it that this one doesn't need to be preserved in WebKitTestRunnerLib?
> 
> Nope. WebKitTestRunner.exe doesn't need to link with WebKit. It loads WebKitTestRunnerLib.dll by using LoadLibraryW.

I misread your comment. WebKitTestRunnerLib_LIBRARIES includes WebKit.

CMakeLists.txt:

set(WebKitTestRunner_LIBRARIES
    WebKit::JavaScriptCore
    WebCoreTestSupport
    WebKit
)

PlatformWin.cmake:

set(WebKitTestRunnerLib_LIBRARIES
    ${WebKitTestRunner_LIBRARIES}
    Comsuppw
    Oleacc
)

list(APPEND WebKitTestRunner_LIBRARIES
    shlwapi
)
Comment 6 Fujii Hironori 2019-11-06 18:05:30 PST 
Committed r252165: <https://trac.webkit.org/changeset/252165>
Comment 7 Radar WebKit Bug Importer 2019-11-06 18:06:18 PST 
<rdar://problem/56967581>