Bug 203821

Summary: REGRESSION (r248750): Drop-down menu for Walgreens 2FA unresponsive to touch
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: UI EventsAssignee: Wenson Hsieh <wenson_hsieh>
Status: NEW ---    
Severity: Normal CC: bdakin, commit-queue, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
zalan: review+
Patch for landing none

Description Wenson Hsieh 2019-11-04 12:54:39 PST
<rdar://problem/56550488>
Comment 1 Wenson Hsieh 2019-11-04 14:10:44 PST
Created attachment 382772 [details]
Patch
Comment 2 zalan 2019-11-04 14:20:57 PST
Comment on attachment 382772 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382772&action=review

> Source/WebCore/page/ios/ContentChangeObserver.h:74
> +    void didNotStartFixedObservationTimerAfterMouseMove();

I'd call it willNotProceedWithFixedObservationTimeWindow
Comment 3 Wenson Hsieh 2019-11-04 14:24:26 PST
Comment on attachment 382772 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382772&action=review

>> Source/WebCore/page/ios/ContentChangeObserver.h:74
>> +    void didNotStartFixedObservationTimerAfterMouseMove();
> 
> I'd call it willNotProceedWithFixedObservationTimeWindow

Sounds good! Changed to willNotProceedWithFixedObservationTimeWindow() and WillNotProceedWithFixedObservationTimeWindow
Comment 4 Wenson Hsieh 2019-11-04 15:02:18 PST
Created attachment 382777 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-11-04 15:48:54 PST
Comment on attachment 382777 [details]
Patch for landing

Clearing flags on attachment: 382777

Committed r252022: <https://trac.webkit.org/changeset/252022>