Bug 203813

Summary: http/tests/resourceLoadStatistics/cookie-deletion.html is timing out
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: Tools / TestsAssignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson, commit-queue, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Kate Cheney
Reported 2019-11-04 09:16:23 PST
http/tests/resourceLoadStatistics/cookie-deletion.html is timing out on macOS
Attachments
Patch (5.68 KB, patch)
2019-11-04 09:28 PST, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Patch (10.21 KB, patch)
2019-11-18 15:32 PST, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Patch (6.29 KB, patch)
2019-11-20 11:35 PST, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kate Cheney
Comment 1 2019-11-04 09:28:18 PST
Created attachment 382745 [details] Patch
Brady Eidson
Comment 2 2019-11-04 09:58:35 PST
Comment on attachment 382745 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382745&action=review > LayoutTests/http/tests/resourceLoadStatistics/cookie-deletion.html:8 > +<body onload="setTimeout(function () { start() }, 1000);"> This guarantees that this test will take a a full second to get started (1000ms timeout) That's generally too slow for a test that doesn't truly need to take that long. Is there a reason a 0-timeout doesn't work? Or at least much less than a second?
Kate Cheney
Comment 3 2019-11-18 15:32:00 PST
Created attachment 383798 [details] Patch
Alexey Proskuryakov
Comment 4 2019-11-18 16:14:57 PST
Comment on attachment 383798 [details] Patch rs=me, please wait for more EWS to complete
WebKit Commit Bot
Comment 5 2019-11-19 08:28:26 PST
Comment on attachment 383798 [details] Patch Clearing flags on attachment: 383798 Committed r252630: <https://trac.webkit.org/changeset/252630>
WebKit Commit Bot
Comment 6 2019-11-19 08:28:27 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-11-19 08:29:18 PST
<rdar://problem/57322805>
Kate Cheney
Comment 8 2019-11-20 11:35:46 PST
Reopening to attach new patch.
Kate Cheney
Comment 9 2019-11-20 11:35:47 PST
Created attachment 383976 [details] Patch
John Wilander
Comment 10 2019-11-20 11:52:21 PST
Comment on attachment 383976 [details] Patch Yeah, let’s try this. If EWS is happy, so am I.
Kate Cheney
Comment 11 2019-11-20 16:23:44 PST
Mac-debug-wk1 seems to have been re-running because of the same unrelated flaky tests for the last 4 hours.
WebKit Commit Bot
Comment 12 2019-11-20 17:09:29 PST
Comment on attachment 383976 [details] Patch Clearing flags on attachment: 383976 Committed r252720: <https://trac.webkit.org/changeset/252720>
WebKit Commit Bot
Comment 13 2019-11-20 17:09:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.