| Summary: | http/tests/resourceLoadStatistics/cookie-deletion.html is timing out | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kate Cheney <katherine_cheney> | ||||||||
| Component: | Tools / Tests | Assignee: | Kate Cheney <katherine_cheney> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ap, beidson, commit-queue, webkit-bug-importer, wilander | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Local Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Kate Cheney
2019-11-04 09:16:23 PST
Created attachment 382745 [details]
Patch
Comment on attachment 382745 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382745&action=review > LayoutTests/http/tests/resourceLoadStatistics/cookie-deletion.html:8 > +<body onload="setTimeout(function () { start() }, 1000);"> This guarantees that this test will take a a full second to get started (1000ms timeout) That's generally too slow for a test that doesn't truly need to take that long. Is there a reason a 0-timeout doesn't work? Or at least much less than a second? Created attachment 383798 [details]
Patch
Comment on attachment 383798 [details]
Patch
rs=me, please wait for more EWS to complete
Comment on attachment 383798 [details] Patch Clearing flags on attachment: 383798 Committed r252630: <https://trac.webkit.org/changeset/252630> All reviewed patches have been landed. Closing bug. Reopening to attach new patch. Created attachment 383976 [details]
Patch
Comment on attachment 383976 [details]
Patch
Yeah, let’s try this. If EWS is happy, so am I.
Mac-debug-wk1 seems to have been re-running because of the same unrelated flaky tests for the last 4 hours. Comment on attachment 383976 [details] Patch Clearing flags on attachment: 383976 Committed r252720: <https://trac.webkit.org/changeset/252720> All reviewed patches have been landed. Closing bug. |