Bug 20379

Summary:

WebCore has too many graphics #ifdefs

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Clean up AffineTransform.h	sam: review+
Clean up GlyphBuffer.h	ap: review+
Remove unneed includes from HTMLCanvas and use the Gradient platform abstraction	ap: review+
Move us one step closer to cross-platform svg/graphics code	bdakin: review+

Eric Seidel (no email)

Reported 2008-08-13 23:05:29 PDT

WebCore still has way too many graphics #ifdefs. We have nice platform solutions, we just don't deploy them everywhere. I've attached a few more rounds of cleanup patches.

Attachments
Clean up AffineTransform.h (5.10 KB, patch) 2008-08-13 23:07 PDT, Eric Seidel (no email)	sam: review+	Details Formatted Diff Diff
Clean up GlyphBuffer.h (2.41 KB, patch) 2008-08-13 23:07 PDT, Eric Seidel (no email)	ap: review+	Details Formatted Diff Diff
Remove unneed includes from HTMLCanvas and use the Gradient platform abstraction (1.65 KB, patch) 2008-08-13 23:07 PDT, Eric Seidel (no email)	ap: review+	Details Formatted Diff Diff
Move us one step closer to cross-platform svg/graphics code (6.69 KB, patch) 2008-08-14 15:48 PDT, Eric Seidel (no email)	bdakin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2008-08-13 23:06:09 PDT

I will of course add ChangeLogs to each after review. ChangeLogs + git rebase don't get along nicely. :( And no resolve-ChangeLog does not count as a full solution.

Eric Seidel (no email)

Comment 2 2008-08-13 23:07:18 PDT

Created attachment 22785 [details] Clean up AffineTransform.h WebCore/platform/graphics/AffineTransform.h | 34 ++++--------------- .../graphics/cairo/AffineTransformCairo.cpp | 2 +- WebCore/platform/graphics/cg/AffineTransformCG.cpp | 8 ++-- WebCore/platform/graphics/qt/AffineTransformQt.cpp | 2 +- WebCore/platform/graphics/wx/AffineTransformWx.cpp | 2 +- 5 files changed, 14 insertions(+), 34 deletions(-)

Eric Seidel (no email)

Comment 3 2008-08-13 23:07:21 PDT

Created attachment 22786 [details] Clean up GlyphBuffer.h WebCore/platform/graphics/GlyphBuffer.h | 45 ++++++++++++++++--------------- 1 files changed, 23 insertions(+), 22 deletions(-)

Eric Seidel (no email)

Comment 4 2008-08-13 23:07:23 PDT

Created attachment 22787 [details] Remove unneed includes from HTMLCanvas and use the Gradient platform abstraction WebCore/html/CanvasRenderingContext2D.cpp | 4 +--- WebCore/html/CanvasStyle.cpp | 1 - WebCore/html/HTMLCanvasElement.cpp | 7 ------- 3 files changed, 1 insertions(+), 11 deletions(-)

Sam Weinig

Comment 5 2008-08-13 23:09:02 PDT

Comment on attachment 22785 [details] Clean up AffineTransform.h Needs a ChangeLog.

Alexey Proskuryakov

Comment 6 2008-08-13 23:58:14 PDT

Comment on attachment 22786 [details] Clean up GlyphBuffer.h r=me

Alexey Proskuryakov

Comment 7 2008-08-14 00:03:13 PDT

Comment on attachment 22787 [details] Remove unneed includes from HTMLCanvas and use the Gradient platform abstraction r=me

Eric Seidel (no email)

Comment 8 2008-08-14 15:48:40 PDT

Created attachment 22800 [details] Move us one step closer to cross-platform svg/graphics code WebCore/WebCore.xcodeproj/project.pbxproj | 3 -- WebCore/html/CanvasStyle.cpp | 7 ----- WebCore/platform/graphics/Color.cpp | 7 +++++ WebCore/platform/graphics/Color.h | 2 +- WebCore/svg/graphics/cg/CgSupport.cpp | 7 +++-- WebCore/svg/graphics/cg/SVGPaintServerSolidCg.cpp | 27 ++++++++++----------- 6 files changed, 25 insertions(+), 28 deletions(-)

Beth Dakin

Comment 9 2008-08-14 16:07:49 PDT

Comment on attachment 22800 [details] Move us one step closer to cross-platform svg/graphics code r=me!

Note You need to log in before you can comment on or make changes to this bug.