WebCore has too many graphics #ifdefs

• Component: New Bugs
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

WebCore still has way too many graphics #ifdefs.  We have nice platform solutions, we just don't deploy them everywhere.  I've attached a few more rounds of cleanup patches.

[Eric Seidel (no email)]

I will of course add ChangeLogs to each after review.  ChangeLogs + git rebase don't get along nicely. :(  And no resolve-ChangeLog does not count as a full solution.

[Eric Seidel (no email)]

Created attachment 22785 [details]
Clean up AffineTransform.h

 WebCore/platform/graphics/AffineTransform.h        |   34 ++++---------------
 .../graphics/cairo/AffineTransformCairo.cpp        |    2 +-
 WebCore/platform/graphics/cg/AffineTransformCG.cpp |    8 ++--
 WebCore/platform/graphics/qt/AffineTransformQt.cpp |    2 +-
 WebCore/platform/graphics/wx/AffineTransformWx.cpp |    2 +-
 5 files changed, 14 insertions(+), 34 deletions(-)

[Eric Seidel (no email)]

Created attachment 22786 [details]
Clean up GlyphBuffer.h

 WebCore/platform/graphics/GlyphBuffer.h |   45 ++++++++++++++++---------------
 1 files changed, 23 insertions(+), 22 deletions(-)

[Eric Seidel (no email)]

Created attachment 22787 [details]
Remove unneed includes from HTMLCanvas and use the Gradient platform abstraction

 WebCore/html/CanvasRenderingContext2D.cpp |    4 +---
 WebCore/html/CanvasStyle.cpp              |    1 -
 WebCore/html/HTMLCanvasElement.cpp        |    7 -------
 3 files changed, 1 insertions(+), 11 deletions(-)

[Sam Weinig]

Comment on attachment 22785 [details]
Clean up AffineTransform.h

Needs a ChangeLog.

[Alexey Proskuryakov]

Comment on attachment 22786 [details]
Clean up GlyphBuffer.h

r=me

[Alexey Proskuryakov]

Comment on attachment 22787 [details]
Remove unneed includes from HTMLCanvas and use the Gradient platform abstraction

r=me

[Eric Seidel (no email)]

Created attachment 22800 [details]
Move us one step closer to cross-platform svg/graphics code

 WebCore/WebCore.xcodeproj/project.pbxproj         |    3 --
 WebCore/html/CanvasStyle.cpp                      |    7 -----
 WebCore/platform/graphics/Color.cpp               |    7 +++++
 WebCore/platform/graphics/Color.h                 |    2 +-
 WebCore/svg/graphics/cg/CgSupport.cpp             |    7 +++--
 WebCore/svg/graphics/cg/SVGPaintServerSolidCg.cpp |   27 ++++++++++-----------
 6 files changed, 25 insertions(+), 28 deletions(-)

[Beth Dakin]

Comment on attachment 22800 [details]
Move us one step closer to cross-platform svg/graphics code

r=me!