Bug 203787

Summary: LLIntGenerator should not allocate temporaries in between variables
Product: WebKit Reporter: Tadeu Zagallo <tzagallo>
Component: JavaScriptCoreAssignee: Tadeu Zagallo <tzagallo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, sbarati, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Tadeu Zagallo 2019-11-02 12:09:57 PDT
...
Comment 1 Tadeu Zagallo 2019-11-02 12:30:32 PDT
Created attachment 382684 [details]
Patch
Comment 2 Tadeu Zagallo 2019-11-02 12:32:06 PDT
<rdar://problem/56840003>
Comment 3 Yusuke Suzuki 2019-11-02 22:58:51 PDT
Comment on attachment 382684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382684&action=review

r=me

> Source/JavaScriptCore/wasm/WasmValidate.cpp:178
> +    void finishedParsingLocals() { }

In WebCore, this type of callback is named as didFinishParsingLocals. Can you align it to this?
Comment 4 Tadeu Zagallo 2019-11-03 19:17:15 PST
Comment on attachment 382684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382684&action=review

Thanks for the review!

>> Source/JavaScriptCore/wasm/WasmValidate.cpp:178
>> +    void finishedParsingLocals() { }
> 
> In WebCore, this type of callback is named as didFinishParsingLocals. Can you align it to this?

Sure, I'll update it before landing.
Comment 5 Tadeu Zagallo 2019-11-03 19:29:20 PST
Created attachment 382714 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-11-03 20:11:50 PST
Comment on attachment 382714 [details]
Patch for landing

Clearing flags on attachment: 382714

Committed r251978: <https://trac.webkit.org/changeset/251978>
Comment 7 WebKit Commit Bot 2019-11-03 20:11:52 PST
All reviewed patches have been landed.  Closing bug.