Bug 203779

Summary: [LFC][Verification] Forced line break display runs don't have TextContext
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description zalan 2019-11-02 06:08:45 PDT
Since they are not text runs.
Comment 1 Radar WebKit Bug Importer 2019-11-02 06:09:03 PDT
<rdar://problem/56839710>
Comment 2 zalan 2019-11-02 06:16:54 PDT
Created attachment 382675 [details]
Patch
Comment 3 zalan 2019-11-02 06:18:14 PDT
Created attachment 382676 [details]
Patch
Comment 4 Antti Koivisto 2019-11-03 01:10:59 PST
Comment on attachment 382676 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382676&action=review

> Source/WebCore/layout/Verification.cpp:127
>          && areEssentiallyEqual(inlineTextBox.logicalRight(), inlineRun.logicalRight())
>          && areEssentiallyEqual(inlineTextBox.logicalTop(), inlineRun.logicalTop())
>          && areEssentiallyEqual(inlineTextBox.logicalBottom(), inlineRun.logicalBottom())

There is areEssentiallyEqual for LayoutRects that could be used here.
Comment 5 zalan 2019-11-03 14:56:10 PST
(In reply to Antti Koivisto from comment #4)
> Comment on attachment 382676 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=382676&action=review
> 
> > Source/WebCore/layout/Verification.cpp:127
> >          && areEssentiallyEqual(inlineTextBox.logicalRight(), inlineRun.logicalRight())
> >          && areEssentiallyEqual(inlineTextBox.logicalTop(), inlineRun.logicalTop())
> >          && areEssentiallyEqual(inlineTextBox.logicalBottom(), inlineRun.logicalBottom())
> 
> There is areEssentiallyEqual for LayoutRects that could be used here.

This local version of areEssentiallyEqual is a bit more relaxed than a generic areEssentiallyEqual function (the epsilon covers cases when a final geometry value goes through a handful of arithmetic conversions)
Comment 6 WebKit Commit Bot 2019-11-03 15:39:08 PST
Comment on attachment 382676 [details]
Patch

Clearing flags on attachment: 382676

Committed r251977: <https://trac.webkit.org/changeset/251977>
Comment 7 WebKit Commit Bot 2019-11-03 15:39:10 PST
All reviewed patches have been landed.  Closing bug.