Summary: | [LFC][Verification] Forced line break display runs don't have TextContext | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
zalan
2019-11-02 06:08:45 PDT
Created attachment 382675 [details]
Patch
Created attachment 382676 [details]
Patch
Comment on attachment 382676 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382676&action=review > Source/WebCore/layout/Verification.cpp:127 > && areEssentiallyEqual(inlineTextBox.logicalRight(), inlineRun.logicalRight()) > && areEssentiallyEqual(inlineTextBox.logicalTop(), inlineRun.logicalTop()) > && areEssentiallyEqual(inlineTextBox.logicalBottom(), inlineRun.logicalBottom()) There is areEssentiallyEqual for LayoutRects that could be used here. (In reply to Antti Koivisto from comment #4) > Comment on attachment 382676 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=382676&action=review > > > Source/WebCore/layout/Verification.cpp:127 > > && areEssentiallyEqual(inlineTextBox.logicalRight(), inlineRun.logicalRight()) > > && areEssentiallyEqual(inlineTextBox.logicalTop(), inlineRun.logicalTop()) > > && areEssentiallyEqual(inlineTextBox.logicalBottom(), inlineRun.logicalBottom()) > > There is areEssentiallyEqual for LayoutRects that could be used here. This local version of areEssentiallyEqual is a bit more relaxed than a generic areEssentiallyEqual function (the epsilon covers cases when a final geometry value goes through a handful of arithmetic conversions) Comment on attachment 382676 [details] Patch Clearing flags on attachment: 382676 Committed r251977: <https://trac.webkit.org/changeset/251977> All reviewed patches have been landed. Closing bug. |