Bug 203777

Summary: Consolidate forEachViewInHierarchy and findAllViewsInHierarchyOfType into common helper file
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: Tools / TestsAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, megan_gardner, thorton, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 203116    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
thorton: review+
Patch for landing none

Wenson Hsieh
Reported 2019-11-01 21:52:55 PDT
SSIA
Attachments
Patch (14.72 KB, patch)
2019-11-01 21:58 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (14.86 KB, patch)
2019-11-01 22:45 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (13.16 KB, patch)
2019-11-01 23:59 PDT, Wenson Hsieh 		thorton: review+
DetailsFormatted DiffDiff
Patch for landing (13.16 KB, patch)
2019-11-04 13:04 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2019-11-01 21:58:20 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 2 2019-11-01 22:45:35 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 3 2019-11-01 23:59:05 PDT
Created attachment 382671 [details] Patch
Tim Horton
Comment 4 2019-11-04 11:16:50 PST
Comment on attachment 382671 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382671&action=review > Tools/WebKitTestRunner/cocoa/PlatformViewHelpers.h:26 > +#pragma once Maybe straight into TestRunnerShared?
Wenson Hsieh
Comment 5 2019-11-04 12:08:26 PST
Thanks for the review! (In reply to Tim Horton from comment #4) > Comment on attachment 382671 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=382671&action=review > > > Tools/WebKitTestRunner/cocoa/PlatformViewHelpers.h:26 > > +#pragma once > > Maybe straight into TestRunnerShared? 👍🏻 will do.
Wenson Hsieh
Comment 6 2019-11-04 13:04:37 PST
Created attachment 382763 [details] Patch for landing
WebKit Commit Bot
Comment 7 2019-11-04 13:49:43 PST
Comment on attachment 382763 [details] Patch for landing Clearing flags on attachment: 382763 Committed r252012: <https://trac.webkit.org/changeset/252012>
Note You need to log in before you can comment on or make changes to this bug.