Bug 203777 - Consolidate forEachViewInHierarchy and findAllViewsInHierarchyOfType into common helper file
Summary: Consolidate forEachViewInHierarchy and findAllViewsInHierarchyOfType into com...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks: 203116
  Show dependency tree / graph
 
Reported: 2019-11-01 21:52 PDT by Wenson Hsieh
Modified: 2019-11-04 14:15 PST (History)
5 users (show)

See Also:

Attachments
Patch (14.72 KB, patch)
2019-11-01 21:58 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (14.86 KB, patch)
2019-11-01 22:45 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (13.16 KB, patch)
2019-11-01 23:59 PDT, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
Patch for landing (13.16 KB, patch)
2019-11-04 13:04 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-11-01 21:52:55 PDT 
SSIA
Comment 1 Wenson Hsieh 2019-11-01 21:58:20 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2019-11-01 22:45:35 PDT Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2019-11-01 23:59:05 PDT 
Created attachment 382671 [details]
Patch
Comment 4 Tim Horton 2019-11-04 11:16:50 PST 
Comment on attachment 382671 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382671&action=review

> Tools/WebKitTestRunner/cocoa/PlatformViewHelpers.h:26
> +#pragma once

Maybe straight into TestRunnerShared?
Comment 5 Wenson Hsieh 2019-11-04 12:08:26 PST 
Thanks for the review!

(In reply to Tim Horton from comment #4)
> Comment on attachment 382671 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=382671&action=review
> 
> > Tools/WebKitTestRunner/cocoa/PlatformViewHelpers.h:26
> > +#pragma once
> 
> Maybe straight into TestRunnerShared?

👍🏻 will do.
Comment 6 Wenson Hsieh 2019-11-04 13:04:37 PST 
Created attachment 382763 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2019-11-04 13:49:43 PST 
Comment on attachment 382763 [details]
Patch for landing

Clearing flags on attachment: 382763

Committed r252012: <https://trac.webkit.org/changeset/252012>