| Summary: | [WebAuthn] CtapAuthenticator::tryDowngrade should distinguish requestData().options | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||||
| Component: | WebKit Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, jiewen_tan, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 181943 | ||||||||
| Attachments: |
|
||||||||
|
Description
Jiewen Tan
2019-11-01 16:26:44 PDT
Created attachment 382657 [details]
Patch
Comment on attachment 382657 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382657&action=review > Source/WebKit/ChangeLog:14 > + No tests given there is no way to spoof google.com in our test infrastructures. It might be better to say, "... no way to simulate google.com in our test infrastructure." Comment on attachment 382657 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382657&action=review Thanks Brent for r+ this patch. Waiting EWS before landing. >> Source/WebKit/ChangeLog:14 >> + No tests given there is no way to spoof google.com in our test infrastructures. > > It might be better to say, "... no way to simulate google.com in our test infrastructure." Fixed. Created attachment 382716 [details]
Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 382716 [details]: imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker.html bug 202003 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. Comment on attachment 382716 [details] Patch for landing Clearing flags on attachment: 382716 Committed r251979: <https://trac.webkit.org/changeset/251979> |