Bug 203771

Summary: [WebAuthn] CtapAuthenticator::tryDowngrade should distinguish requestData().options
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebKit Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 181943    
Attachments:
Description Flags
Patch
bfulgham: review+
Patch for landing none

Jiewen Tan
Reported 2019-11-01 16:26:44 PDT
CtapAuthenticator::tryDowngrade should distinguish requestData().options.
Attachments
Patch (2.44 KB, patch)
2019-11-01 17:06 PDT, Jiewen Tan 		bfulgham: review+
DetailsFormatted DiffDiff
Patch for landing (2.44 KB, patch)
2019-11-03 22:34 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-11-01 16:42:16 PDT
<rdar://problem/56832618>
Jiewen Tan
Comment 2 2019-11-01 17:06:53 PDT
Created attachment 382657 [details] Patch
Brent Fulgham
Comment 3 2019-11-01 17:28:00 PDT
Comment on attachment 382657 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382657&action=review > Source/WebKit/ChangeLog:14 > + No tests given there is no way to spoof google.com in our test infrastructures. It might be better to say, "... no way to simulate google.com in our test infrastructure."
Jiewen Tan
Comment 4 2019-11-01 17:37:51 PDT
Comment on attachment 382657 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382657&action=review Thanks Brent for r+ this patch. Waiting EWS before landing. >> Source/WebKit/ChangeLog:14 >> + No tests given there is no way to spoof google.com in our test infrastructures. > > It might be better to say, "... no way to simulate google.com in our test infrastructure." Fixed.
Jiewen Tan
Comment 5 2019-11-03 22:34:00 PST
Created attachment 382716 [details] Patch for landing
WebKit Commit Bot
Comment 6 2019-11-03 23:32:50 PST
The commit-queue encountered the following flaky tests while processing attachment 382716 [details]: imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker.html bug 202003 (author: youennf@gmail.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2019-11-03 23:33:35 PST
Comment on attachment 382716 [details] Patch for landing Clearing flags on attachment: 382716 Committed r251979: <https://trac.webkit.org/changeset/251979>
Note You need to log in before you can comment on or make changes to this bug.