Bug 203755

Summary:

Update SameSite tests for new semantics for empty and invalid SameSite attribute

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, tsavell, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=203910

Attachments:

Description	Flags
Patch	none
To Land	none

Description Daniel Bates 2019-11-01 13:43:02 PDT

Update the tests and test expectations following CFNetwork change <rdar://problem/42290578> as we now only recognize SameSite=Strict and SameSite=Lax. That is, we no longer treat SameSite= or SameSite=<some garbage value> as SameSite=Strict.

Comment 1 Daniel Bates 2019-11-01 13:43:27 PDT

<rdar://problem/50816282>

Comment 2 Daniel Bates 2019-11-01 13:55:08 PDT

Created attachment 382623 [details]
Patch

Comment 3 Brent Fulgham 2019-11-06 09:17:29 PST

Comment on attachment 382623 [details]
Patch

r=me

Comment 4 Daniel Bates 2019-11-06 09:34:56 PST

Comment on attachment 382623 [details]
Patch

Clearing flags on attachment: 382623

Committed r252138: <https://trac.webkit.org/changeset/252138>

Comment 5 Daniel Bates 2019-11-06 09:34:58 PST

All reviewed patches have been landed.  Closing bug.

Comment 6 Truitt Savell 2019-11-06 11:56:01 PST

The changes in https://trac.webkit.org/changeset/252138/webkit

broek 8 http/tests/cookies/same-site/ tests

tracking in https://bugs.webkit.org/show_bug.cgi?id=203910

Comment 7 Truitt Savell 2019-11-06 14:21:26 PST

Reverted r252138 for reason:

Caused 8 http/tests/cookies/same-site/ to fail

Committed r252149: <https://trac.webkit.org/changeset/252149>

Comment 8 Daniel Bates 2019-11-06 15:01:57 PST

Created attachment 382963 [details]
To Land

Comment 9 Daniel Bates 2019-11-06 15:03:22 PST

Committed r252153: <https://trac.webkit.org/changeset/252153>