| Summary: | [JSC] OSR exit to LLInt is broken on MIPS | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Caio Lima <ticaiolima> | ||||||
| Component: | JavaScriptCore | Assignee: | Caio Lima <ticaiolima> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, ews-watchlist, guijemont, jbedard, jsc32, keith_miller, mark.lam, msaboff, rniwa, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Caio Lima
2019-11-01 07:39:43 PDT
Skipping another failing test with similar backtrace in Bug 204003. New broken test: stress/ensure-code-block-is-not-precise-allocation.js.dfg-eager Created attachment 383862 [details]
Patch
Comment on attachment 383862 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383862&action=review This looks like the right approach, assuming tests pass. > Source/JavaScriptCore/ChangeLog:14 > + `OFFLINE_ASM_CPLOAD` macro) immideatly after a non-local label. With typo: immediately > Source/JavaScriptCore/ChangeLog:19 > + emmit code using the correct register required to recalculate `$gp`. typo: emit Created attachment 383870 [details]
Patch
Comment on attachment 383870 [details]
Patch
r=me
Comment on attachment 383870 [details]
Patch
Thank you very much for the review!
The commit-queue encountered the following flaky tests while processing attachment 383870 [details]:
The commit-queue is continuing to process your patch.
The commit-queue encountered the following flaky tests while processing attachment 383870 [details]: imported/w3c/web-platform-tests/fetch/api/basic/mode-same-origin.any.html bug 204421 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. Comment on attachment 383870 [details] Patch Clearing flags on attachment: 383870 Committed r252713: <https://trac.webkit.org/changeset/252713> All reviewed patches have been landed. Closing bug. |