Bug 203736

Summary: [ews] Pass clobber-old-results parameter to run-webkit-tests
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, jbedard, ryanhaddad, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2019-11-01 07:17:20 PDT
Pass --clobber-old-results to run-webkit-tests. This will also match will build.webkit.org configuration: https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py#L418
Attachments
Patch (10.61 KB, patch)
2019-11-01 07:19 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-11-01 07:19:55 PDT
Created attachment 382575 [details] Patch
Aakash Jain
Comment 2 2019-11-01 07:22:56 PDT
I haven't tested this one on uat instance. This is a speculative (and a simple) change to make the EWS configuration similar to build.webkit.org. Also logically, passing --clobber-test-results shouldn't cause any issue as it's just more cleanup.
Jonathan Bedard
Comment 3 2019-11-01 09:32:35 PDT
Comment on attachment 382575 [details] Patch This change is obviously correct, we should have been doing it from the beginning.
WebKit Commit Bot
Comment 4 2019-11-01 10:27:43 PDT
Comment on attachment 382575 [details] Patch Clearing flags on attachment: 382575 Committed r251927: <https://trac.webkit.org/changeset/251927>
WebKit Commit Bot
Comment 5 2019-11-01 10:27:52 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-11-01 10:28:18 PDT
<rdar://problem/56820127>
Note You need to log in before you can comment on or make changes to this bug.