Summary: | gcSafeMemmove references undefined slowPathBackwardsMemmove on non-gcc compatible compilers | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tadeu Zagallo <tzagallo> | ||||
Component: | JavaScriptCore | Assignee: | Tadeu Zagallo <tzagallo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, ews-watchlist, Hironori.Fujii, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, ysuzuki | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Tadeu Zagallo
2019-10-31 21:14:15 PDT
Created attachment 382547 [details]
Patch
Comment on attachment 382547 [details]
Patch
LGTM. Thank you very much.
Thanks for the review! Comment on attachment 382547 [details] Patch Clearing flags on attachment: 382547 Committed r251909: <https://trac.webkit.org/changeset/251909> All reviewed patches have been landed. Closing bug. Reverted in r251967 together with r251875, because this patch was conflicting with the rollback. Sorry for the inconvenience. I'm not sure if this was a fix after r251875, or a fix of its own (didn't look at the code). Please close or re-land as appropriate. It is already landed. |