Bug 203713

Summary: Take down the gesture snapshot early when the back/forward cache is not leveraged
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED WONTFIX    
Severity: Normal CC: commit-queue, ggaren, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=202293
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Chris Dumez 2019-10-31 18:46:11 PDT
Take down the gesture snapshot as soon as the gesture is done when the back/forward cache is not leveraged. Otherwise, the snapshot may stay up for a long time (while we load, parse and restore scroll position) and it looks to the user as if the view is unresponsive. Showing the back loading in such cases is less confusing.
Comment 1 Radar WebKit Bug Importer 2019-10-31 18:49:51 PDT
<rdar://problem/56803910>
Comment 2 Chris Dumez 2019-10-31 18:53:49 PDT
Created attachment 382534 [details]
Patch
Comment 3 Chris Dumez 2019-10-31 18:55:15 PDT
Created attachment 382535 [details]
Patch
Comment 4 Chris Dumez 2019-10-31 19:14:38 PDT
Created attachment 382538 [details]
Patch
Comment 5 WebKit Commit Bot 2019-10-31 21:07:44 PDT
Comment on attachment 382538 [details]
Patch

Clearing flags on attachment: 382538

Committed r251907: <https://trac.webkit.org/changeset/251907>
Comment 6 WebKit Commit Bot 2019-10-31 21:07:46 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Chris Dumez 2019-11-06 15:53:49 PST
Reverted r251907 for reason:

Causes white flashing in some cases <rdar://problem/56957850>

Committed r252155: <https://trac.webkit.org/changeset/252155>