Bug 203696

Summary: [JSC] Make String#localeCompare faster by inlining JSGlobalObject::defaultCollator
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Yusuke Suzuki
Reported 2019-10-31 13:46:09 PDT
[JSC] Make String#localeCompare faster by inlining JSGlobalObject::defaultCollator
Attachments
Patch (8.60 KB, patch)
2019-10-31 13:47 PDT, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-10-31 13:47:12 PDT
Created attachment 382497 [details] Patch
Mark Lam
Comment 2 2019-10-31 14:00:48 PDT
Comment on attachment 382497 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382497&action=review r=me with fix and if EWS bots are green. > Source/JavaScriptCore/runtime/JSGlobalObject.cpp:903 > + scope.assertNoException(); Since you're expecting no exception, use DECLARE_CATCH_SCOPE instead of DECLARE_THROW_SCOPE? Might as well make this a releaseAssertNoException() too.
Yusuke Suzuki
Comment 3 2019-10-31 14:01:35 PDT
Comment on attachment 382497 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382497&action=review >> Source/JavaScriptCore/runtime/JSGlobalObject.cpp:903 >> + scope.assertNoException(); > > Since you're expecting no exception, use DECLARE_CATCH_SCOPE instead of DECLARE_THROW_SCOPE? Might as well make this a releaseAssertNoException() too. Sounds nice. Fixed.
Yusuke Suzuki
Comment 4 2019-10-31 14:53:23 PDT
Committed r251882: <https://trac.webkit.org/changeset/251882>
Radar WebKit Bug Importer
Comment 5 2019-10-31 14:54:16 PDT
<rdar://problem/56796383>
Note You need to log in before you can comment on or make changes to this bug.