| Summary: | [JSC] Make String#localeCompare faster by inlining JSGlobalObject::defaultCollator | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2019-10-31 13:46:09 PDT
Created attachment 382497 [details]
Patch
Comment on attachment 382497 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382497&action=review r=me with fix and if EWS bots are green. > Source/JavaScriptCore/runtime/JSGlobalObject.cpp:903 > + scope.assertNoException(); Since you're expecting no exception, use DECLARE_CATCH_SCOPE instead of DECLARE_THROW_SCOPE? Might as well make this a releaseAssertNoException() too. Comment on attachment 382497 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382497&action=review >> Source/JavaScriptCore/runtime/JSGlobalObject.cpp:903 >> + scope.assertNoException(); > > Since you're expecting no exception, use DECLARE_CATCH_SCOPE instead of DECLARE_THROW_SCOPE? Might as well make this a releaseAssertNoException() too. Sounds nice. Fixed. Committed r251882: <https://trac.webkit.org/changeset/251882> |