Bug 203696 - [JSC] Make String#localeCompare faster by inlining JSGlobalObject::defaultCollator
Summary: [JSC] Make String#localeCompare faster by inlining JSGlobalObject::defaultCol...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-31 13:46 PDT by Yusuke Suzuki
Modified: 2019-10-31 14:54 PDT (History)
7 users (show)

See Also:


Attachments
Patch (8.60 KB, patch)
2019-10-31 13:47 PDT, Yusuke Suzuki
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-10-31 13:46:09 PDT
[JSC] Make String#localeCompare faster by inlining JSGlobalObject::defaultCollator
Comment 1 Yusuke Suzuki 2019-10-31 13:47:12 PDT
Created attachment 382497 [details]
Patch
Comment 2 Mark Lam 2019-10-31 14:00:48 PDT
Comment on attachment 382497 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382497&action=review

r=me with fix and if EWS bots are green.

> Source/JavaScriptCore/runtime/JSGlobalObject.cpp:903
> +            scope.assertNoException();

Since you're expecting no exception, use DECLARE_CATCH_SCOPE instead of DECLARE_THROW_SCOPE?  Might as well make this a releaseAssertNoException() too.
Comment 3 Yusuke Suzuki 2019-10-31 14:01:35 PDT
Comment on attachment 382497 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382497&action=review

>> Source/JavaScriptCore/runtime/JSGlobalObject.cpp:903
>> +            scope.assertNoException();
> 
> Since you're expecting no exception, use DECLARE_CATCH_SCOPE instead of DECLARE_THROW_SCOPE?  Might as well make this a releaseAssertNoException() too.

Sounds nice. Fixed.
Comment 4 Yusuke Suzuki 2019-10-31 14:53:23 PDT
Committed r251882: <https://trac.webkit.org/changeset/251882>
Comment 5 Radar WebKit Bug Importer 2019-10-31 14:54:16 PDT
<rdar://problem/56796383>