Bug 203694

Summary: Rename Wasm::CodeBlock to Wasm::CalleeGroup
Product: WebKit Reporter: Tadeu Zagallo <tzagallo>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sergio, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Tadeu Zagallo
Reported 2019-10-31 13:30:35 PDT
It's just not a CodeBlock, and it should be called something else.
Attachments
Patch (132.29 KB, patch)
2021-12-15 16:18 PST, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-12-15 16:18:22 PST
Created attachment 447297 [details] Patch
Mark Lam
Comment 2 2021-12-15 16:23:28 PST
Comment on attachment 447297 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447297&action=review r=me > Source/JavaScriptCore/ChangeLog:8 > + This is not a CodeBlock. And it is confusing name to JSC::CodeBlock. I suggest rephrasing as “And the name causes confusion with JSC::CodeBlock, which is not at all related.”
Yusuke Suzuki
Comment 3 2021-12-15 17:04:25 PST
Comment on attachment 447297 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447297&action=review >> Source/JavaScriptCore/ChangeLog:8 >> + This is not a CodeBlock. And it is confusing name to JSC::CodeBlock. > > I suggest rephrasing as “And the name causes confusion with JSC::CodeBlock, which is not at all related.” Thanks, fixed!
Yusuke Suzuki
Comment 4 2021-12-15 18:15:52 PST
Committed r287122 (245306@trunk): <https://commits.webkit.org/245306@trunk>
Radar WebKit Bug Importer
Comment 5 2021-12-15 18:17:38 PST
<rdar://problem/86552840>
Saam Barati
Comment 6 2021-12-16 15:46:04 PST
*** Bug 234101 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.