Bug 203680

Summary: Port ServiceWorkerContainer to the HTML5 event loop
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Service WorkersAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, dbates, esprehn+autocc, ews-watchlist, ggaren, kangil.han, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 202293, 203714    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Chris Dumez 2019-10-31 08:03:38 PDT 
Port ServiceWorkerContainer to the HTML5 event loop, instead of having its own SuspendableTaskQueue.
Comment 1 Chris Dumez 2019-10-31 08:06:27 PDT 
Created attachment 382459 [details]
Patch
Comment 2 Chris Dumez 2019-10-31 10:51:33 PDT 
Created attachment 382478 [details]
Patch
Comment 3 Chris Dumez 2019-10-31 13:07:02 PDT 
Created attachment 382490 [details]
Patch
Comment 4 Chris Dumez 2019-10-31 13:34:33 PDT 
Created attachment 382494 [details]
Patch
Comment 5 Ryosuke Niwa 2019-10-31 16:01:12 PDT 
Comment on attachment 382494 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382494&action=review

> Source/WebCore/workers/WorkerEventLoop.cpp:38
> +    auto eventLoop = adoptRef(*new WorkerEventLoop(context));
> +    eventLoop->suspendIfNeeded();
> +    return eventLoop;

Maybe we can just do this in the constructor?

> Source/WebCore/workers/WorkerEventLoop.cpp:45
> +    eventLoop->suspendIfNeeded();

Ditto.
Comment 6 Chris Dumez 2019-10-31 16:44:07 PDT 
Created attachment 382519 [details]
Patch
Comment 7 WebKit Commit Bot 2019-11-01 12:34:39 PDT 
Comment on attachment 382519 [details]
Patch

Clearing flags on attachment: 382519

Committed r251934: <https://trac.webkit.org/changeset/251934>
Comment 8 WebKit Commit Bot 2019-11-01 12:34:41 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-11-01 12:35:16 PDT 
<rdar://problem/56824994>