Bug 203680

Summary: Port ServiceWorkerContainer to the HTML5 event loop
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Service WorkersAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, dbates, esprehn+autocc, ews-watchlist, ggaren, kangil.han, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 202293, 203714    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2019-10-31 08:03:38 PDT
Port ServiceWorkerContainer to the HTML5 event loop, instead of having its own SuspendableTaskQueue.
Attachments
Patch (8.20 KB, patch)
2019-10-31 08:06 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (9.71 KB, patch)
2019-10-31 10:51 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (9.74 KB, patch)
2019-10-31 13:07 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (10.85 KB, patch)
2019-10-31 13:34 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (10.58 KB, patch)
2019-10-31 16:44 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-10-31 08:06:27 PDT
Created attachment 382459 [details] Patch
Chris Dumez
Comment 2 2019-10-31 10:51:33 PDT
Created attachment 382478 [details] Patch
Chris Dumez
Comment 3 2019-10-31 13:07:02 PDT
Created attachment 382490 [details] Patch
Chris Dumez
Comment 4 2019-10-31 13:34:33 PDT
Created attachment 382494 [details] Patch
Ryosuke Niwa
Comment 5 2019-10-31 16:01:12 PDT
Comment on attachment 382494 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382494&action=review > Source/WebCore/workers/WorkerEventLoop.cpp:38 > + auto eventLoop = adoptRef(*new WorkerEventLoop(context)); > + eventLoop->suspendIfNeeded(); > + return eventLoop; Maybe we can just do this in the constructor? > Source/WebCore/workers/WorkerEventLoop.cpp:45 > + eventLoop->suspendIfNeeded(); Ditto.
Chris Dumez
Comment 6 2019-10-31 16:44:07 PDT
Created attachment 382519 [details] Patch
WebKit Commit Bot
Comment 7 2019-11-01 12:34:39 PDT
Comment on attachment 382519 [details] Patch Clearing flags on attachment: 382519 Committed r251934: <https://trac.webkit.org/changeset/251934>
WebKit Commit Bot
Comment 8 2019-11-01 12:34:41 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-11-01 12:35:16 PDT
<rdar://problem/56824994>
Note You need to log in before you can comment on or make changes to this bug.