Bug 203654

Summary: Rename AccessibilityObject::matchedParent as Accessibility::findAncestor and re-implement in a generic way so that can be used with both AccessibilityObjects and AXIsolatedTreeNodes.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, ews-feeder, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andres Gonzalez
Reported 2019-10-30 19:01:45 PDT
Rename AccessibilityObject::matchedParent as Accessibility::findAncestor and re-implement in a generic way so that can be used with both AccessibilityObjects and AXIsolatedTreeNodes.
Attachments
Patch (24.09 KB, patch)
2019-10-30 19:12 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (24.10 KB, patch)
2019-10-31 05:32 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andres Gonzalez
Comment 1 2019-10-30 19:12:15 PDT
Created attachment 382408 [details] Patch
chris fleizach
Comment 2 2019-10-30 23:46:05 PDT
Comment on attachment 382408 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382408&action=review approved pending fixes of minor nits > Source/WebCore/ChangeLog:12 > + - Created the namespace Accessibility for implementation deatils that not need to be exposed to client code. deatils > details > Source/WebCore/accessibility/AccessibilityObjectInterface.h:1103 > +} // namespace ax // namespace Accessibility
Andres Gonzalez
Comment 3 2019-10-31 05:32:45 PDT
Created attachment 382453 [details] Patch
Andres Gonzalez
Comment 4 2019-10-31 05:36:26 PDT
Fixed the nits you pointed out. Thanks.
EWS
Comment 5 2019-10-31 05:37:53 PDT
Comment on attachment 382453 [details] Patch Rejecting attachment 382453 [details] from commit-queue. andresg_22@apple.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Commit Bot
Comment 6 2019-10-31 12:59:28 PDT
Comment on attachment 382453 [details] Patch Clearing flags on attachment: 382453 Committed r251870: <https://trac.webkit.org/changeset/251870>
WebKit Commit Bot
Comment 7 2019-10-31 12:59:30 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-10-31 13:00:17 PDT
<rdar://problem/56791932>
Note You need to log in before you can comment on or make changes to this bug.