| Summary: | Rejigger WKWebArchive headers | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||||
| Component: | WebKit API | Assignee: | Brady Eidson <beidson> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | aakash_jain, aestes, ap, commit-queue, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Brady Eidson
2019-10-30 17:26:57 PDT
Created attachment 382398 [details]
Patch
Created attachment 382468 [details]
Patch
Comment on attachment 382468 [details] Patch Clearing flags on attachment: 382468 Committed r251854: <https://trac.webkit.org/changeset/251854> All reviewed patches have been landed. Closing bug. Comment on attachment 382468 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382468&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebArchive.h:27 > +#include <WebKit/WKWebArchiveRef.h> I know this is just for staging, but if it were to stay we should use #import here. (In reply to Andy Estes from comment #6) > Comment on attachment 382468 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=382468&action=review > > > Source/WebKit/UIProcess/API/Cocoa/WKWebArchive.h:27 > > +#include <WebKit/WKWebArchiveRef.h> > > I know this is just for staging, but if it were to stay we should use > #import here. It will NOT stay. (In reply to WebKit Commit Bot from comment #3) > Committed r251854: <https://trac.webkit.org/changeset/251854> This seems to have broken the iOS build, as also indicated by EWS. Relevant logs: Source/WebKit/Shared/API/c/mac/WKWebArchiveRef.cpp:42:17: error: no previous prototype for function 'WKWebArchiveCreate' [-Werror,-Wmissing-prototypes] WKWebArchiveRef WKWebArchiveCreate(WKWebArchiveResourceRef mainResourceRef, WKArrayRef subresourcesRef, WKArrayRef subframeArchivesRef) Source/WebKit/Shared/API/c/mac/WKWebArchiveRef.cpp:72:12: error: no previous prototype for function 'WKWebArchiveCopySubframeArchives' [-Werror,-Wmissing-prototypes] WKArrayRef WKWebArchiveCopySubframeArchives(WKWebArchiveRef webArchiveRef) Reverted r251854 for reason: Broke iOS build Committed r251868: <https://trac.webkit.org/changeset/251868> Created attachment 382595 [details]
Patch
Comment on attachment 382595 [details] Patch Rejecting attachment 382595 [details] from commit-queue. New failing tests: requestidlecallback/requestidlecallback-document-gc.html Full output: https://webkit-queues.webkit.org/results/13201898 Created attachment 382613 [details]
Archive of layout-test-results from webkit-cq-01 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01 Port: mac-highsierra Platform: Mac OS X 10.13.6
(In reply to WebKit Commit Bot from comment #12) > Comment on attachment 382595 [details] > Patch > > Rejecting attachment 382595 [details] from commit-queue. > > New failing tests: > requestidlecallback/requestidlecallback-document-gc.html > Full output: https://webkit-queues.webkit.org/results/13201898 This patch did not cause this failure. (In reply to Brady Eidson from comment #14) > > New failing tests: > > requestidlecallback/requestidlecallback-document-gc.html > This patch did not cause this failure. You are right. This is a flaky test. See: https://bugs.webkit.org/show_bug.cgi?id=203758 Comment on attachment 382595 [details] Patch Clearing flags on attachment: 382595 Committed r251952: <https://trac.webkit.org/changeset/251952> All reviewed patches have been landed. Closing bug. |