Bug 203648

Summary:

Rejigger WKWebArchive headers

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebKit API

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, aestes, ap, commit-queue, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from webkit-cq-01 for mac-highsierra	none

Brady Eidson

Reported 2019-10-30 17:26:57 PDT

Rejigger WKWebArchive headers -Rename WKWebArchive.h to WKWebArchiveRef.h -Add a new WKWebArchive.h that includes the Ref version

Attachments
Patch (23.66 KB, patch) 2019-10-30 17:31 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (23.68 KB, patch) 2019-10-31 09:38 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (23.69 KB, patch) 2019-11-01 11:01 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-cq-01 for mac-highsierra (3.70 MB, application/zip) 2019-11-01 13:23 PDT, WebKit Commit Bot	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2019-10-30 17:31:13 PDT

Created attachment 382398 [details] Patch

Brady Eidson

Comment 2 2019-10-31 09:38:10 PDT

Created attachment 382468 [details] Patch

WebKit Commit Bot

Comment 3 2019-10-31 10:22:24 PDT

Comment on attachment 382468 [details] Patch Clearing flags on attachment: 382468 Committed r251854: <https://trac.webkit.org/changeset/251854>

WebKit Commit Bot

Comment 4 2019-10-31 10:22:26 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 5 2019-10-31 10:23:19 PDT

<rdar://problem/56785948>

Andy Estes

Comment 6 2019-10-31 10:23:51 PDT

Comment on attachment 382468 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382468&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebArchive.h:27 > +#include <WebKit/WKWebArchiveRef.h> I know this is just for staging, but if it were to stay we should use #import here.

Brady Eidson

Comment 7 2019-10-31 12:00:40 PDT

(In reply to Andy Estes from comment #6) > Comment on attachment 382468 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=382468&action=review > > > Source/WebKit/UIProcess/API/Cocoa/WKWebArchive.h:27 > > +#include <WebKit/WKWebArchiveRef.h> > > I know this is just for staging, but if it were to stay we should use > #import here. It will NOT stay.

Aakash Jain

Comment 8 2019-10-31 12:24:12 PDT

(In reply to WebKit Commit Bot from comment #3) > Committed r251854: <https://trac.webkit.org/changeset/251854> This seems to have broken the iOS build, as also indicated by EWS.

Aakash Jain

Comment 9 2019-10-31 12:24:17 PDT

Relevant logs: Source/WebKit/Shared/API/c/mac/WKWebArchiveRef.cpp:42:17: error: no previous prototype for function 'WKWebArchiveCreate' [-Werror,-Wmissing-prototypes] WKWebArchiveRef WKWebArchiveCreate(WKWebArchiveResourceRef mainResourceRef, WKArrayRef subresourcesRef, WKArrayRef subframeArchivesRef) Source/WebKit/Shared/API/c/mac/WKWebArchiveRef.cpp:72:12: error: no previous prototype for function 'WKWebArchiveCopySubframeArchives' [-Werror,-Wmissing-prototypes] WKArrayRef WKWebArchiveCopySubframeArchives(WKWebArchiveRef webArchiveRef)

Truitt Savell

Comment 10 2019-10-31 12:29:56 PDT

Reverted r251854 for reason: Broke iOS build Committed r251868: <https://trac.webkit.org/changeset/251868>

Brady Eidson

Comment 11 2019-11-01 11:01:11 PDT

Created attachment 382595 [details] Patch

WebKit Commit Bot

Comment 12 2019-11-01 13:23:33 PDT

Comment on attachment 382595 [details] Patch Rejecting attachment 382595 [details] from commit-queue. New failing tests: requestidlecallback/requestidlecallback-document-gc.html Full output: https://webkit-queues.webkit.org/results/13201898

WebKit Commit Bot

Comment 13 2019-11-01 13:23:34 PDT

Created attachment 382613 [details] Archive of layout-test-results from webkit-cq-01 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-01 Port: mac-highsierra Platform: Mac OS X 10.13.6

Brady Eidson

Comment 14 2019-11-01 14:43:40 PDT

(In reply to WebKit Commit Bot from comment #12) > Comment on attachment 382595 [details] > Patch > > Rejecting attachment 382595 [details] from commit-queue. > > New failing tests: > requestidlecallback/requestidlecallback-document-gc.html > Full output: https://webkit-queues.webkit.org/results/13201898 This patch did not cause this failure.

Aakash Jain

Comment 15 2019-11-01 15:15:29 PDT

(In reply to Brady Eidson from comment #14) > > New failing tests: > > requestidlecallback/requestidlecallback-document-gc.html > This patch did not cause this failure. You are right. This is a flaky test. See: https://bugs.webkit.org/show_bug.cgi?id=203758

WebKit Commit Bot

Comment 16 2019-11-01 16:34:34 PDT

Comment on attachment 382595 [details] Patch Clearing flags on attachment: 382595 Committed r251952: <https://trac.webkit.org/changeset/251952>

WebKit Commit Bot

Comment 17 2019-11-01 16:34:36 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.