Bug 203629

Summary:

Issue mach sandbox extension to the WebContent process for "com.apple.distributed_notifications@1v3"

Product:

WebKit

Reporter:

Per Arne Vollan <pvollan>

Component:

WebKit Misc.

Assignee:

Per Arne Vollan <pvollan>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

ap, bfulgham, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

203618

Bug Blocks:

Attachments:

Description	Flags
Patch	bfulgham: review+
Patch	none

Per Arne Vollan

Reported 2019-10-30 14:36:51 PDT

This service is only being used by the injected bundle of WebKitTestRunner during layout tests, and we should therefore issue an extension instead of allowing the service in the WebContent sandbox.

Attachments
Patch (6.76 KB, patch) 2019-10-30 14:44 PDT, Per Arne Vollan	bfulgham: review+	Details Formatted Diff Diff
Patch (7.47 KB, patch) 2019-10-31 10:18 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-10-30 14:37:13 PDT

<rdar://problem/56758948>

Per Arne Vollan

Comment 2 2019-10-30 14:44:03 PDT

Created attachment 382359 [details] Patch

Brent Fulgham

Comment 3 2019-10-30 14:54:08 PDT

Comment on attachment 382359 [details] Patch Excellent! r=me

Per Arne Vollan

Comment 4 2019-10-30 15:30:00 PDT

(In reply to Brent Fulgham from comment #3) > Comment on attachment 382359 [details] > Patch > > Excellent! r=me The build is failing since this patch depends on https://bugs.webkit.org/show_bug.cgi?id=203618. Thanks for reviewing!

Alexey Proskuryakov

Comment 5 2019-10-30 23:20:11 PDT

> This service is only being used by the injected bundle of WebKitTestRunner during layout tests That's so strange. Why? Can we stop WebKitTestRunner injected bundle from using it?

Per Arne Vollan

Comment 6 2019-10-31 10:05:52 PDT

(In reply to Alexey Proskuryakov from comment #5) > > This service is only being used by the injected bundle of WebKitTestRunner during layout tests > > That's so strange. Why? Can we stop WebKitTestRunner injected bundle from > using it? This is caused by WebKitTestRunner's injected bundle calling CTFontManagerRegisterFontsForURLs. This seems to be related to activating test fonts. Thanks for reviewing!

Per Arne Vollan

Comment 7 2019-10-31 10:18:30 PDT

Created attachment 382474 [details] Patch

Alexey Proskuryakov

Comment 8 2019-10-31 16:17:21 PDT

Comment on attachment 382474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382474&action=review > Source/WebCore/ChangeLog:3 > + Issue mach sandbox extension to the WebContent process for "com.apple.distributed_notifications@1v3" Seems like we don't need this any more? Because of bug 203697.

Brent Fulgham

Comment 9 2019-10-31 16:45:44 PDT

(In reply to Alexey Proskuryakov from comment #8) > Comment on attachment 382474 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=382474&action=review > > > Source/WebCore/ChangeLog:3 > > + Issue mach sandbox extension to the WebContent process for "com.apple.distributed_notifications@1v3" > > Seems like we don't need this any more? Because of bug 203697. I think we still want this, but should likely add it to one of our new "needed by InjectedBundle" init routines. But this patch should change to move the blanket allow in Bug 203697 to a targeted allow based on Bundle ID.

Brent Fulgham

Comment 10 2022-02-12 23:39:47 PST

This turned out to not be needed.

Note You need to log in before you can comment on or make changes to this bug.