Summary: | Opacity should always serialize as a number | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||||
Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | commit-queue, dino, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, krit, macpherson, menard, philipj, sabouhallawa, sergio, simon.fraser, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2019-10-29 21:27:04 PDT
Created attachment 382278 [details]
Patch
Created attachment 382280 [details]
Patch
Created attachment 382284 [details]
Patch
Comment on attachment 382284 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382284&action=review The change looks good to me though I have no official reviewer status at the moment. > Source/WebCore/css/StyleProperties.cpp:128 > + case CSSPropertyOpacity: Consider adding the SVG -opacity properties: fill, stroke, stop, flood. They behave just like opacity. Created attachment 382316 [details]
Patch
Created attachment 382325 [details]
Patch
The patch fixes these tests: imported/w3c/web-platform-tests/svg/painting/parsing/stroke-opacity-valid.svg imported/w3c/web-platform-tests/svg/painting/parsing/fill-opacity-valid.svg imported/w3c/web-platform-tests/svg/pservers/parsing/stop-opacity-valid.svg They were unskipped in r251777. The expected files need to be rebaselined. Reopening to attach new patch. Created attachment 382418 [details]
Patch
|