Bug 203601

Summary: Opacity should always serialize as a number
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, krit, macpherson, menard, philipj, sabouhallawa, sergio, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
dino: review+, sabouhallawa: commit-queue-
Patch none

Simon Fraser (smfr)
Reported 2019-10-29 21:27:04 PDT
Opacity should always serialize as a number
Attachments
Patch (4.04 KB, patch)
2019-10-29 21:27 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (293.71 KB, patch)
2019-10-29 22:14 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (6.16 KB, patch)
2019-10-29 23:03 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (6.32 KB, patch)
2019-10-30 08:28 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (16.87 KB, patch)
2019-10-30 09:45 PDT, Simon Fraser (smfr) 		dino: review+
sabouhallawa: commit-queue-
DetailsFormatted DiffDiff
Patch (655.87 KB, patch)
2019-10-30 21:03 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2019-10-29 21:27:53 PDT
Created attachment 382278 [details] Patch
Radar WebKit Bug Importer
Comment 2 2019-10-29 21:29:23 PDT
<rdar://problem/56733247>
Simon Fraser (smfr)
Comment 3 2019-10-29 22:14:11 PDT
Created attachment 382280 [details] Patch
Simon Fraser (smfr)
Comment 4 2019-10-29 23:03:45 PDT
Created attachment 382284 [details] Patch
Dirk Schulze
Comment 5 2019-10-30 00:32:39 PDT
Comment on attachment 382284 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382284&action=review The change looks good to me though I have no official reviewer status at the moment. > Source/WebCore/css/StyleProperties.cpp:128 > + case CSSPropertyOpacity: Consider adding the SVG -opacity properties: fill, stroke, stop, flood. They behave just like opacity.
Simon Fraser (smfr)
Comment 6 2019-10-30 08:28:29 PDT
Created attachment 382316 [details] Patch
Simon Fraser (smfr)
Comment 7 2019-10-30 09:45:02 PDT
Created attachment 382325 [details] Patch
Said Abou-Hallawa
Comment 8 2019-10-30 13:13:03 PDT
The patch fixes these tests: imported/w3c/web-platform-tests/svg/painting/parsing/stroke-opacity-valid.svg imported/w3c/web-platform-tests/svg/painting/parsing/fill-opacity-valid.svg imported/w3c/web-platform-tests/svg/pservers/parsing/stop-opacity-valid.svg They were unskipped in r251777. The expected files need to be rebaselined.
Simon Fraser (smfr)
Comment 9 2019-10-30 19:17:37 PDT
https://trac.webkit.org/changeset/251828/webkit
Simon Fraser (smfr)
Comment 10 2019-10-30 21:03:55 PDT Comment hidden (obsolete)
Simon Fraser (smfr)
Comment 11 2019-10-30 21:03:57 PDT Comment hidden (obsolete)
Note You need to log in before you can comment on or make changes to this bug.