Bug 203542 – Layout Test http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration-database.html is a flaky failure

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Kate Cheney]

http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration-database.html is failing almost every other run. 


flakiness dashboard: 
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2FresourceLoadStatistics%2Fwebsite-data-removal-for-site-navigated-to-with-link-decoration-database.html

Currently unable to reproduce locally. 

Likely cause:
scheduleStatisticsProcessingRequestIfNecessary() is messing with the callback in website-data-removal-for-site-navigated-to-with-link-decoration-database.html The test calls processStatisticsAndDataRecords() manually when it is finished making changes.

[Radar WebKit Bug Importer]

<rdar://problem/56689764>

[Kate Cheney]

Created attachment 382140 [details]
Patch

[John Wilander]

Comment on attachment 382140 [details]
Patch

LGTM

[EWS]

Comment on attachment 382140 [details]
Patch

Rejecting attachment 382140 [details] from commit-queue.

[e-mail] does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Kate Cheney]

Guess I'm still too early...

[EWS]

Comment on attachment 382140 [details]
Patch

Rejecting attachment 382140 [details] from commit-queue.

[e-mail] does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[EWS]

Comment on attachment 382140 [details]
Patch

Rejecting attachment 382140 [details] from commit-queue.

[e-mail] does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Truitt Savell]

*** Bug 203576 has been marked as a duplicate of this bug. ***

[WebKit Commit Bot]

Comment on attachment 382140 [details]
Patch

Clearing flags on attachment: 382140

Committed r251719: <https://trac.webkit.org/changeset/251719>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.