Bug 20352

Summary: REGRESSION(r31030-31055): Choosing "Print window" from frame set prints blank page
Product: WebKit Reporter: Gavin Sherlock <gsherloc>
Component: PrintingAssignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin
Priority: P1 Keywords: InRadar, NeedsReduction, Regression
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
URL: http://www.tbdb.org/cgi-bin/expression/gx_expression.pl?pubNo=694&n=4363
Attachments:
Description Flags
Reduction
none
Patch darin: review+

Gavin Sherlock
Reported 2008-08-11 17:26:41 PDT
Steps to reproduce: 1. Go to bug url 2. Right click, and select "Print Window" from contextual menu Expected results: The entire contents of the window will be printed Actual results: A blank page Regression - yes - this does not happen in Safari 3.1.2. Tested with r35666 on 10.5.4 on a Mac Pro.
Attachments
Reduction (2.15 KB, application/zip)
2008-10-21 17:13 PDT, Beth Dakin 		no flags
Details
Patch (1.42 KB, patch)
2008-10-21 17:21 PDT, Beth Dakin 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2008-08-11 17:29:08 PDT
<rdar://problem/6142398>
Gavin Sherlock
Comment 2 2008-08-11 23:05:48 PDT
r31030 works, r31055 fails
Gavin Sherlock
Comment 3 2008-08-11 23:11:56 PDT
I suspect http://trac.webkit.org/changeset/31037 though this is only an untrained eye looking at it.
Beth Dakin
Comment 4 2008-10-21 16:21:06 PDT
Interestingly, the page prints fine if you press command-P or choose Print from the File menu. Only printing with "Print Window" through the context menu is broken.
Beth Dakin
Comment 5 2008-10-21 17:13:58 PDT
Created attachment 24547 [details] Reduction Here is a reduction. I think I have a patch too. Will post shortly.
Beth Dakin
Comment 6 2008-10-21 17:21:09 PDT
Created attachment 24548 [details] Patch
Darin Adler
Comment 7 2008-10-21 17:21:57 PDT
Comment on attachment 24548 [details] Patch r=me
Beth Dakin
Comment 8 2008-10-21 17:23:30 PDT
Fixed with r37768.
Note You need to log in before you can comment on or make changes to this bug.