Summary: | [GTK] Get DumpRenderTree working | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alp Toker <alp> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | mrowe | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Alp Toker
2008-08-11 16:07:25 PDT
A good first step may be to add a flag to run-webkit-tests that has it ignore non-text-only results (eg, render tree dumps). Dealing with the font metric issue for render trees is rather tricky, and I think a lot more benefit can be gained from a) fixing the obvious crashers, and b) fixing any text-only tests that fail, before working on the render tree side of things. Created attachment 22835 [details]
DRT fixes
Fixes and enhancements to GTK+'s DRT tool.
Comment on attachment 22835 [details]
DRT fixes
Great step ahead.
You should get various new unused parameter warnings, e.g. just omit the parameter name and you are fine.
The flushing should fix quite some issues.
The cosmetic changes are I fine and besides personal taste I could not find anything in the Coding Style Guidelines to forbid comments at the end of the line.
The removal of WorkQueue::shared()->clear() and addition of webkit_web_view_open is something the other DRTs don't do. You are definitely right that some results depend on the order of the tests...
|