Bug 203496

Summary: Expose _printOperationWithPrintInfo: SPI as API
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit APIAssignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, commit-queue
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Brady Eidson
Reported 2019-10-28 11:38:48 PDT
Expose _printOperationWithPrintInfo: SPI as API
Attachments
Patch (4.35 KB, patch)
2019-10-28 11:40 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (4.28 KB, patch)
2019-10-28 12:29 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (4.27 KB, patch)
2019-10-28 13:00 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2019-10-28 11:39:04 PDT
<rdar://problem/36557179>
Brady Eidson
Comment 2 2019-10-28 11:40:57 PDT
Created attachment 382086 [details] Patch
Andy Estes
Comment 3 2019-10-28 11:44:02 PDT
Comment on attachment 382086 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382086&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.h:307 > +/* @abstract Returns an NSPrintOperation object configured to print the contents of this WKWebView > +@param printInfo The print info object used to configure the resulting print operation. > +*/ > +- (NSPrintOperation *)printOperationWithPrintInfo:(NSPrintInfo *)printInfo WK_API_AVAILABLE(macos(WK_MAC_TBA)); > + Should this be part of one of the !TARGET_OS_IPHONE sections either above or below?
Brady Eidson
Comment 4 2019-10-28 12:29:16 PDT
Created attachment 382094 [details] Patch
Brady Eidson
Comment 5 2019-10-28 13:00:33 PDT
Created attachment 382097 [details] Patch
WebKit Commit Bot
Comment 6 2019-10-28 14:42:50 PDT
Comment on attachment 382097 [details] Patch Clearing flags on attachment: 382097 Committed r251673: <https://trac.webkit.org/changeset/251673>
WebKit Commit Bot
Comment 7 2019-10-28 14:42:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.