| Summary: | Layout Test http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html is a flaky failure | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kate Cheney <katherine_cheney> | ||||||
| Component: | WebKit Misc. | Assignee: | Kate Cheney <katherine_cheney> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, cdumez, commit-queue, webkit-bug-importer, wilander | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Kate Cheney
2019-10-28 10:30:10 PDT
Created attachment 382081 [details]
Patch
Comment on attachment 382081 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382081&action=review > Source/WebKit/NetworkProcess/NetworkSession.cpp:181 > + if (!networkProcess().isITPDatabaseEnabled()) Instead of having these checks at call sites, could we maybe call populateMemoryStoreFromDisk() unconditionally and add a null check for the persistent store in populateMemoryStoreFromDisk()? Created attachment 382084 [details]
Patch
(In reply to Chris Dumez from comment #3) > Comment on attachment 382081 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=382081&action=review > > > Source/WebKit/NetworkProcess/NetworkSession.cpp:181 > > + if (!networkProcess().isITPDatabaseEnabled()) > > Instead of having these checks at call sites, could we maybe call > populateMemoryStoreFromDisk() unconditionally and add a null check for the > persistent store in populateMemoryStoreFromDisk()? Thanks! Still waiting on commit privileges, can you cq+? Comment on attachment 382084 [details] Patch Clearing flags on attachment: 382084 Committed r251672: <https://trac.webkit.org/changeset/251672> All reviewed patches have been landed. Closing bug. |