Bug 203491

Summary: Layout Test http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html is a flaky failure
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: WebKit Misc.Assignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Kate Cheney
Reported 2019-10-28 10:30:10 PDT
Previously fixed in <rdar://problem/51074251>. Started flaking again after fixing <rdar://problem/56314484>.
Attachments
Patch (10.20 KB, patch)
2019-10-28 10:47 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Patch (10.07 KB, patch)
2019-10-28 11:17 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-10-28 10:31:12 PDT
<rdar://problem/56674176>
Kate Cheney
Comment 2 2019-10-28 10:47:46 PDT
Created attachment 382081 [details] Patch
Chris Dumez
Comment 3 2019-10-28 10:52:25 PDT
Comment on attachment 382081 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382081&action=review > Source/WebKit/NetworkProcess/NetworkSession.cpp:181 > + if (!networkProcess().isITPDatabaseEnabled()) Instead of having these checks at call sites, could we maybe call populateMemoryStoreFromDisk() unconditionally and add a null check for the persistent store in populateMemoryStoreFromDisk()?
Kate Cheney
Comment 4 2019-10-28 11:17:08 PDT
Created attachment 382084 [details] Patch
Kate Cheney
Comment 5 2019-10-28 13:50:30 PDT
(In reply to Chris Dumez from comment #3) > Comment on attachment 382081 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=382081&action=review > > > Source/WebKit/NetworkProcess/NetworkSession.cpp:181 > > + if (!networkProcess().isITPDatabaseEnabled()) > > Instead of having these checks at call sites, could we maybe call > populateMemoryStoreFromDisk() unconditionally and add a null check for the > persistent store in populateMemoryStoreFromDisk()? Thanks! Still waiting on commit privileges, can you cq+?
WebKit Commit Bot
Comment 6 2019-10-28 14:38:33 PDT
Comment on attachment 382084 [details] Patch Clearing flags on attachment: 382084 Committed r251672: <https://trac.webkit.org/changeset/251672>
WebKit Commit Bot
Comment 7 2019-10-28 14:38:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.