Bug 203486

Summary: dumpSpeculation in SpeculatedType.cpp prints to the wrong stream and has wrong capitalization for NaN
Product: WebKit Reporter: Tuomas Karkkainen <tuomas.webkit>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Trivial CC: commit-queue, ews-watchlist, keith_miller, koivisto, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch none

Tuomas Karkkainen
Reported 2019-10-28 06:53:40 PDT
in void dumpSpeculation(PrintStream& outStream, SpeculatedType value) in SpeculatedType.cpp, "DoubleImpureNan" is printed to out when it should be printed to strOut. also DoubleImpureNan and DoublePureNan should both end with a capital N.
Attachments
proposed patch (1.38 KB, patch)
2019-10-28 06:58 PDT, Tuomas Karkkainen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tuomas Karkkainen
Comment 1 2019-10-28 06:58:05 PDT
Created attachment 382067 [details] proposed patch
WebKit Commit Bot
Comment 2 2019-10-28 13:21:55 PDT
Comment on attachment 382067 [details] proposed patch Clearing flags on attachment: 382067 Committed r251667: <https://trac.webkit.org/changeset/251667>
WebKit Commit Bot
Comment 3 2019-10-28 13:21:56 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-10-28 13:28:52 PDT
<rdar://problem/56682260>
Note You need to log in before you can comment on or make changes to this bug.