| Summary: | CSS Transitions and CSS Animations properties should treat unitless 0 as an invalid value for times | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||||
| Component: | Animations | Assignee: | Antoine Quint <graouts> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | dino, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, koivisto, macpherson, menard, nickshanks, simon.fraser, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=113230 https://bugs.webkit.org/show_bug.cgi?id=155870 https://bugs.webkit.org/show_bug.cgi?id=141023 |
||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 203477 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Antoine Quint
2019-10-28 03:20:47 PDT
Created attachment 382060 [details]
Patch
Comment on attachment 382060 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382060&action=review > Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:450 > + bool acceptUnitless = token.type() == NumberToken && unitless == UnitlessQuirk::Allow && shouldAcceptUnitlessValue(token.numericValue(), cssParserMode, unitless); Why does it still need to be accepted in quirks mode? (In reply to Antti Koivisto from comment #2) > Comment on attachment 382060 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=382060&action=review > > > Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:450 > > + bool acceptUnitless = token.type() == NumberToken && unitless == UnitlessQuirk::Allow && shouldAcceptUnitlessValue(token.numericValue(), cssParserMode, unitless); > > Why does it still need to be accepted in quirks mode? This is so -webkit-marquee-speed, which is the only property for which UnitlessQuirk is set to Allow, does not change behavior. Only transition-delay, animation-duration and animation-delay are affected. Comment on attachment 382060 [details] Patch Attachment 382060 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13184947 New failing tests: css1/units/zero-duration-without-units.html transitions/zero-duration-without-units.html animations/fill-mode-forwards-zero-duration.html legacy-animation-engine/animations/fill-mode-forwards-zero-duration.html css3/filters/blur-various-radii.html legacy-animation-engine/compositing/animation/keyframe-order.html transitions/zero-duration-in-list.html Created attachment 382066 [details]
Archive of layout-test-results from ews213 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews213 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 382073 [details]
Patch
Committed r251658: <https://trac.webkit.org/changeset/251658> *** Bug 204947 has been marked as a duplicate of this bug. *** |