Bug 203472

Summary: [Quick Look] Clean up LegacyPreviewLoaderClients
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, cdumez, commit-queue, dbates, ews-watchlist, japhet, koivisto, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Andy Estes
Reported 2019-10-27 13:17:42 PDT
[Quick Look] Clean up LegacyPreviewLoaderClients
Attachments
Patch (45.50 KB, patch)
2019-10-27 13:27 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (52.51 KB, patch)
2019-10-29 14:48 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (52.51 KB, patch)
2019-10-29 16:51 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2019-10-27 13:27:27 PDT
Created attachment 382032 [details] Patch
Andy Estes
Comment 2 2019-10-29 14:48:30 PDT
Created attachment 382230 [details] Patch
Brady Eidson
Comment 3 2019-10-29 16:35:34 PDT
Comment on attachment 382230 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382230&action=review > Source/WebKit/Platform/SharedMemory.cpp:35 > +RefPtr<SharedMemory> SharedMemory::create(const SharedBuffer& buffer) I was a little confused here, trying to figure out how you could make an existing become "shared memory" I'd like the name to be more clear that the new SharedMemory object is a copy. Maybe "createWithCopy" or something explicit like that. > Source/WebKit/Platform/SharedMemory.h:104 > static RefPtr<SharedMemory> create(void*, size_t, Protection); > + static RefPtr<SharedMemory> create(const WebCore::SharedBuffer&); I know the existence of this one is just as confusing. I would've made the same comment when it was added. (Unless, of course,I am the one who added it)
Andy Estes
Comment 4 2019-10-29 16:51:56 PDT
Created attachment 382252 [details] Patch
WebKit Commit Bot
Comment 5 2019-10-29 21:14:47 PDT
Comment on attachment 382252 [details] Patch Clearing flags on attachment: 382252 Committed r251765: <https://trac.webkit.org/changeset/251765>
WebKit Commit Bot
Comment 6 2019-10-29 21:14:49 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-10-29 21:15:19 PDT
<rdar://problem/56733040>
Note You need to log in before you can comment on or make changes to this bug.