| Summary: | [Quick Look] Clean up LegacyPreviewLoaderClients | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||||||
| Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, beidson, cdumez, commit-queue, dbates, ews-watchlist, japhet, koivisto, thorton, webkit-bug-importer, wenson_hsieh | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Andy Estes
2019-10-27 13:17:42 PDT
Created attachment 382032 [details]
Patch
Created attachment 382230 [details]
Patch
Comment on attachment 382230 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382230&action=review > Source/WebKit/Platform/SharedMemory.cpp:35 > +RefPtr<SharedMemory> SharedMemory::create(const SharedBuffer& buffer) I was a little confused here, trying to figure out how you could make an existing become "shared memory" I'd like the name to be more clear that the new SharedMemory object is a copy. Maybe "createWithCopy" or something explicit like that. > Source/WebKit/Platform/SharedMemory.h:104 > static RefPtr<SharedMemory> create(void*, size_t, Protection); > + static RefPtr<SharedMemory> create(const WebCore::SharedBuffer&); I know the existence of this one is just as confusing. I would've made the same comment when it was added. (Unless, of course,I am the one who added it) Created attachment 382252 [details]
Patch
Comment on attachment 382252 [details] Patch Clearing flags on attachment: 382252 Committed r251765: <https://trac.webkit.org/changeset/251765> All reviewed patches have been landed. Closing bug. |