Bug 20343

Summary:

[CAIRO] half functionality of border-radius

Product:

WebKit

Reporter:

Dirk Schulze <krit>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

Cairo

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

URL:

http://www.the-art-of-web.com/css/border-radius/

Attachments:

Description	Flags
Fixes border-radius	eric: review+

Dirk Schulze

Reported 2008-08-10 23:08:44 PDT

border-radius doesn't support different values for with-radius and height-radius (ellipse) and dotted or dashed borders with border-radius look strange.

Attachments
Fixes border-radius (3.81 KB, patch) 2008-08-10 23:12 PDT, Dirk Schulze	eric: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dirk Schulze

Comment 1 2008-08-10 23:12:10 PDT

Created attachment 22724 [details] Fixes border-radius This is nearly a copy of the Mac-part with adaptions to cairo.

Eric Seidel (no email)

Comment 2 2008-08-22 02:27:49 PDT

Comment on attachment 22724 [details] Fixes border-radius I'm not sure I 100% understand the code, but it looks sane enough. falen really could have a better variable name. "fa" too. It seems sad there is not a slicker way to handle this: + if (w != h) + cairo_scale(cr, 1., scaleFactor); + + cairo_arc_negative(cr, x + hRadius, (y + vRadius) * reverseScaleFactor, hRadius, -fa * M_PI/180, -falen * M_PI/180); + + if (w != h) + cairo_scale(cr, 1., reverseScaleFactor); + w/o setting and un-setting the scale factor.

Jan Alonzo

Comment 3 2008-09-01 05:45:57 PDT

landed in r36011

Note You need to log in before you can comment on or make changes to this bug.