| Summary: | Add SSL support for peformance dashboard database connection. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | dewei_zhu | ||||
| Component: | New Bugs | Assignee: | dewei_zhu | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dewei_zhu, rniwa | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
dewei_zhu
2019-10-25 11:29:51 PDT
Created attachment 381948 [details]
Patch
Comment on attachment 381948 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381948&action=review > Websites/perf.webkit.org/public/include/db.php:121 > + $connectionString = 'host=' . $databaseConfig['host'] . ' port=' . $databaseConfig['port'] > + . ' dbname=' . $databaseConfig['name'] . ' user=' . $databaseConfig['username'] . ' password=' . $databaseConfig['password']; This string concatenation is hard to read. Can we define local variables and do: "host=$host port=$port dbname=$dbname user=$user password=$password"? > Websites/perf.webkit.org/public/include/db.php:136 > + $sslConfigString .= ' ssl' . $key . '=' . $path; Why not just $sslConfigString .= "ssl $key = $path"? |