Bug 203348

Summary: [Cocoa] Make it possible to convert SharedBuffer segments and data views to NSData without copying
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, dbates, ews-watchlist, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews211 for win-future none

Andy Estes
Reported 2019-10-23 16:34:32 PDT
[Cocoa] Make it possible to convert SharedBuffer segments and data views to NSData without copying
Attachments
Patch (8.01 KB, patch)
2019-10-23 16:41 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (8.89 KB, patch)
2019-10-23 19:44 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (8.91 KB, patch)
2019-10-23 21:04 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews211 for win-future (13.93 MB, application/zip)
2019-10-24 07:08 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2019-10-23 16:41:53 PDT
Created attachment 381753 [details] Patch
Andy Estes
Comment 2 2019-10-23 19:44:47 PDT
Created attachment 381768 [details] Patch
Andy Estes
Comment 3 2019-10-23 21:04:30 PDT
Created attachment 381772 [details] Patch
EWS Watchlist
Comment 4 2019-10-24 07:08:07 PDT
Comment on attachment 381772 [details] Patch Attachment 381772 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13173682 New failing tests: fast/repaint/backgroundSizeRepaint.html
EWS Watchlist
Comment 5 2019-10-24 07:08:09 PDT
Created attachment 381806 [details] Archive of layout-test-results from ews211 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Andy Estes
Comment 6 2019-10-24 10:09:22 PDT
(In reply to Build Bot from comment #4) > Comment on attachment 381772 [details] > Patch > > Attachment 381772 [details] did not pass win-ews (win): > Output: https://webkit-queues.webkit.org/results/13173682 > > New failing tests: > fast/repaint/backgroundSizeRepaint.html win-ews ran this test four times with my patch and it failed 2/4 times, so I think this is just flakiness.
WebKit Commit Bot
Comment 7 2019-10-24 10:51:41 PDT
Comment on attachment 381772 [details] Patch Clearing flags on attachment: 381772 Committed r251546: <https://trac.webkit.org/changeset/251546>
WebKit Commit Bot
Comment 8 2019-10-24 10:51:47 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-10-24 12:40:30 PDT
<rdar://problem/56590051>
Note You need to log in before you can comment on or make changes to this bug.