Bug 203344

Summary: Drop support for NSURLCache callbacks in NetworkProcess
Product: WebKit Reporter: Ben Nham <nham>
Component: WebKit2Assignee: Ben Nham <nham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, darin, koivisto, nham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 205074    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Ben Nham
Reported 2019-10-23 15:26:46 PDT
Since we dropped support for NSURLCache in NetworkProcess in https://bugs.webkit.org/show_bug.cgi?id=185990, it seems like we should also be able to remove our implementation of the -[WKNetworkSessionDelegate URLSession:dataTask:willCacheResponse:completionHandler:] callback.
Attachments
Patch (2.35 KB, patch)
2019-11-18 10:17 PST, Ben Nham 		no flags
DetailsFormatted DiffDiff
Patch (2.38 KB, patch)
2019-12-06 09:54 PST, Ben Nham 		no flags
DetailsFormatted DiffDiff
Patch (2.35 KB, patch)
2019-12-16 12:51 PST, Ben Nham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ben Nham
Comment 1 2019-11-18 10:17:06 PST
Created attachment 383756 [details] Patch
WebKit Commit Bot
Comment 2 2019-11-18 14:42:38 PST
Comment on attachment 383756 [details] Patch Rejecting attachment 383756 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 383756, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/13265086
Ben Nham
Comment 3 2019-12-06 09:54:49 PST
Created attachment 385023 [details] Patch
Ben Nham
Comment 4 2019-12-06 09:55:52 PST
Comment on attachment 385023 [details] Patch Same as previous reviewed patch, but has the "Reviewed by" field filled out to please the commit queue.
WebKit Commit Bot
Comment 5 2019-12-06 13:03:58 PST
Comment on attachment 385023 [details] Patch Clearing flags on attachment: 385023 Committed r253212: <https://trac.webkit.org/changeset/253212>
WebKit Commit Bot
Comment 6 2019-12-06 13:04:00 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-12-06 13:04:18 PST
<rdar://problem/57710222>
WebKit Commit Bot
Comment 8 2019-12-10 12:06:37 PST
Re-opened since this is blocked by bug 205074
Alexey Proskuryakov
Comment 9 2019-12-10 15:27:48 PST
Can the be re-landed now?
Ben Nham
Comment 10 2019-12-16 12:51:59 PST
Created attachment 385799 [details] Patch
Ben Nham
Comment 11 2019-12-16 12:52:49 PST
Comment on attachment 385799 [details] Patch Re-submitting patch for review and commit queue since the original was rolled back incorrectly (it did not cause 205074 as originally reported).
WebKit Commit Bot
Comment 12 2019-12-17 13:23:02 PST
Comment on attachment 385799 [details] Patch Clearing flags on attachment: 385799 Committed r253642: <https://trac.webkit.org/changeset/253642>
WebKit Commit Bot
Comment 13 2019-12-17 13:23:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.