Bug 203339

Summary: Undo incidental change from BytecodeIndex class patch
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Keith Miller
Reported 2019-10-23 14:47:27 PDT
Undo incidental change from BytecodeIndex class patch
Attachments
Patch (2.79 KB, patch)
2019-10-23 14:54 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (2.80 KB, patch)
2019-10-23 15:11 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2019-10-23 14:54:12 PDT
Created attachment 381733 [details] Patch
Keith Miller
Comment 2 2019-10-23 14:54:59 PDT
rdar://problem/56529630
Mark Lam
Comment 3 2019-10-23 15:09:00 PDT
Comment on attachment 381733 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381733&action=review > Source/JavaScriptCore/ChangeLog:11 > + It's not totally clear why we need to claim our bytecode index is > +we can't figure what the true index is. I'd rather unbreak > + our build for now, however, and fix the underlying issue in > + https://bugs.webkit.org/show_bug.cgi?id=203340 Can you fix this?
Keith Miller
Comment 4 2019-10-23 15:10:54 PDT
Comment on attachment 381733 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381733&action=review >> Source/JavaScriptCore/ChangeLog:11 >> + https://bugs.webkit.org/show_bug.cgi?id=203340 > > Can you fix this? Woah, weird. Sure.
Keith Miller
Comment 5 2019-10-23 15:11:00 PDT
Created attachment 381736 [details] Patch
Mark Lam
Comment 6 2019-10-23 15:14:12 PDT
Comment on attachment 381736 [details] Patch r=me if JSC tests are green.
WebKit Commit Bot
Comment 7 2019-10-23 20:09:20 PDT
Comment on attachment 381736 [details] Patch Clearing flags on attachment: 381736 Committed r251525: <https://trac.webkit.org/changeset/251525>
WebKit Commit Bot
Comment 8 2019-10-23 20:09:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.