Bug 203318

Summary: [iOS] Stop including 'common.sb'
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 203352    
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2019-10-23 14:10:47 PDT
The 'common.sb' sandbox file activates many features we do not need in the WebContent process. We should pare down the allowed items. This patch is the first step, which replaces the '(import "common.sb")' with a copy/paste of the contents of the sandbox profile. I also removed anything that was explicitly blocked in a later line of the sandbox, but wanted to minimize changes as much as possible in this first step.
Attachments
Patch (22.55 KB, patch)
2019-10-23 14:19 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2019-10-23 14:11:23 PDT
<rdar://problem/56374092>
Brent Fulgham
Comment 2 2019-10-23 14:19:46 PDT
Created attachment 381726 [details] Patch
Per Arne Vollan
Comment 3 2019-10-23 15:22:28 PDT
Comment on attachment 381726 [details] Patch Great! R=me.
WebKit Commit Bot
Comment 4 2019-10-23 17:02:32 PDT
Comment on attachment 381726 [details] Patch Clearing flags on attachment: 381726 Committed r251511: <https://trac.webkit.org/changeset/251511>
WebKit Commit Bot
Comment 5 2019-10-23 17:02:33 PDT
All reviewed patches have been landed. Closing bug.
Brent Fulgham
Comment 6 2019-10-24 13:28:18 PDT
Note: The following fix was also needed: <https://trac.webkit.org/changeset/251555/webkit>
Note You need to log in before you can comment on or make changes to this bug.