Bug 203274

Summary: Make `JSGlobalObject*` threading change more stabilized by adding tests and assertions
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dbates, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 202392    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch saam: review+

Yusuke Suzuki
Reported 2019-10-22 14:35:04 PDT
Follow-up after r251425
Attachments
Patch (6.32 KB, patch)
2019-10-22 18:19 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (6.35 KB, patch)
2019-10-22 18:21 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (6.67 KB, patch)
2019-10-22 18:32 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (8.72 KB, patch)
2019-10-22 20:18 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-10-22 18:19:55 PDT
Created attachment 381641 [details] Patch
Yusuke Suzuki
Comment 2 2019-10-22 18:21:54 PDT
Created attachment 381642 [details] Patch
Yusuke Suzuki
Comment 3 2019-10-22 18:28:28 PDT
Comment on attachment 381642 [details] Patch Checking.
Yusuke Suzuki
Comment 4 2019-10-22 18:32:51 PDT
Created attachment 381643 [details] Patch
Yusuke Suzuki
Comment 5 2019-10-22 20:18:07 PDT
Created attachment 381648 [details] Patch
Radar WebKit Bug Importer
Comment 6 2019-10-22 20:21:14 PDT
<rdar://problem/56526714>
Saam Barati
Comment 7 2019-10-22 21:39:20 PDT
Comment on attachment 381648 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381648&action=review > Source/JavaScriptCore/ChangeLog:10 > + 1. Add tests that touches vm.topCallFrame from C++ world. “touches” => “tests” And maybe say that you’re testing that it remains null
Yusuke Suzuki
Comment 8 2019-10-22 22:16:00 PDT
Comment on attachment 381648 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381648&action=review I've checked that debug layout-test finishes without assertion hit in EWS. I'll land this :) >> Source/JavaScriptCore/ChangeLog:10 >> + 1. Add tests that touches vm.topCallFrame from C++ world. > > “touches” => “tests” > And maybe say that you’re testing that it remains null Fixed.
Yusuke Suzuki
Comment 9 2019-10-22 22:16:56 PDT
Committed r251475: <https://trac.webkit.org/changeset/251475>
Note You need to log in before you can comment on or make changes to this bug.