Bug 203260

Summary: [JSC] Remove non-LargeAllocation restriction for JSCallee
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, calvaris, cdumez, ews-watchlist, hi, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 203282    
Attachments:
Description Flags
Patch
none
Patch saam: review+

Yusuke Suzuki
Reported 2019-10-22 11:46:31 PDT
[JSC] Remove non-LargeAllocation restriction for JSCallee
Attachments
Patch (3.36 KB, patch)
2019-10-22 11:47 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (59.98 KB, patch)
2019-10-22 14:11 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-10-22 11:47:54 PDT
Created attachment 381574 [details] Patch
Radar WebKit Bug Importer
Comment 2 2019-10-22 11:48:15 PDT
<rdar://problem/56508915>
Yusuke Suzuki
Comment 3 2019-10-22 11:57:48 PDT
Comment on attachment 381574 [details] Patch compile errors. Fix it later
Yusuke Suzuki
Comment 4 2019-10-22 14:11:06 PDT
Created attachment 381600 [details] Patch
Saam Barati
Comment 5 2019-10-22 14:20:44 PDT
Comment on attachment 381600 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381600&action=review > Source/JavaScriptCore/ChangeLog:12 > + This patch renames `CallFrame::vm` to `CallFrame::deprecatedVM`. And we avoid using it as much as possible. can we file a bug on doing refactoring necessary to delete this function?
Yusuke Suzuki
Comment 6 2019-10-22 14:21:30 PDT
Comment on attachment 381600 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381600&action=review >> Source/JavaScriptCore/ChangeLog:12 >> + This patch renames `CallFrame::vm` to `CallFrame::deprecatedVM`. And we avoid using it as much as possible. > > can we file a bug on doing refactoring necessary to delete this function? Filed, https://bugs.webkit.org/show_bug.cgi?id=203272 thanks!
Yusuke Suzuki
Comment 7 2019-10-22 14:23:32 PDT
Committed r251457: <https://trac.webkit.org/changeset/251457>
Mark Lam
Comment 8 2019-10-22 14:30:30 PDT
Comment on attachment 381600 [details] Patch r=me too. Since you're modifying CodeGeneratorJS.pm, you need to rebase the binding test results.
Mark Lam
Comment 9 2019-10-22 15:13:04 PDT
(In reply to Mark Lam from comment #8) > Comment on attachment 381600 [details] > Patch > > r=me too. Since you're modifying CodeGeneratorJS.pm, you need to rebase the > binding test results. I realized afterwards that the bindings tests are passing on the EWS. So, maybe this change is not covered by the tests and no rebasing or results needed.
Note You need to log in before you can comment on or make changes to this bug.