Bug 203260

Summary: [JSC] Remove non-LargeAllocation restriction for JSCallee
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, calvaris, cdumez, ews-watchlist, hi, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 203282    
Attachments:
Description Flags
Patch
none
Patch saam: review+

Description Yusuke Suzuki 2019-10-22 11:46:31 PDT 
[JSC] Remove non-LargeAllocation restriction for JSCallee
Comment 1 Yusuke Suzuki 2019-10-22 11:47:54 PDT 
Created attachment 381574 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-10-22 11:48:15 PDT 
<rdar://problem/56508915>
Comment 3 Yusuke Suzuki 2019-10-22 11:57:48 PDT 
Comment on attachment 381574 [details]
Patch

compile errors. Fix it later
Comment 4 Yusuke Suzuki 2019-10-22 14:11:06 PDT 
Created attachment 381600 [details]
Patch
Comment 5 Saam Barati 2019-10-22 14:20:44 PDT 
Comment on attachment 381600 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381600&action=review

> Source/JavaScriptCore/ChangeLog:12
> +        This patch renames `CallFrame::vm` to `CallFrame::deprecatedVM`. And we avoid using it as much as possible.

can we file a bug on doing refactoring necessary to delete this function?
Comment 6 Yusuke Suzuki 2019-10-22 14:21:30 PDT 
Comment on attachment 381600 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381600&action=review

>> Source/JavaScriptCore/ChangeLog:12
>> +        This patch renames `CallFrame::vm` to `CallFrame::deprecatedVM`. And we avoid using it as much as possible.
> 
> can we file a bug on doing refactoring necessary to delete this function?

Filed, https://bugs.webkit.org/show_bug.cgi?id=203272 thanks!
Comment 7 Yusuke Suzuki 2019-10-22 14:23:32 PDT 
Committed r251457: <https://trac.webkit.org/changeset/251457>
Comment 8 Mark Lam 2019-10-22 14:30:30 PDT 
Comment on attachment 381600 [details]
Patch

r=me too.  Since you're modifying CodeGeneratorJS.pm, you need to rebase the binding test results.
Comment 9 Mark Lam 2019-10-22 15:13:04 PDT 
(In reply to Mark Lam from comment #8)
> Comment on attachment 381600 [details]
> Patch
> 
> r=me too.  Since you're modifying CodeGeneratorJS.pm, you need to rebase the
> binding test results.

I realized afterwards that the bindings tests are passing on the EWS.  So, maybe this change is not covered by the tests and no rebasing or results needed.